chore: Remove old VoIP files and references #37060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Contributor
WalkthroughThis PR removes legacy VoIP UI, hooks, context, client, and related utilities across packages/ui-voip and Meteor client usage. NavBar controls are simplified to only omnichannel items; all VoIP toggler/dialer logic, components, stories, tests, and provider/context are deleted. Root exports are updated to expose MediaCallProvider instead. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NavBarControlsWithData
participant NavBarControlsWithCall
participant NavBarControlsMenu
User->>NavBarControlsWithData: Open controls
NavBarControlsWithData->>NavBarControlsWithCall: Pass omnichannelItems (no VoIP)
NavBarControlsWithCall->>NavBarControlsMenu: omnichannelItemsOnly, isPressed
NavBarControlsMenu->>User: Render Omnichannel section
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (4)
📒 Files selected for processing (95)
💤 Files with no reviewable changes (91)
🔇 Additional comments (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #37060 +/- ##
===========================================
- Coverage 67.41% 67.34% -0.07%
===========================================
Files 3334 3275 -59
Lines 113698 111858 -1840
Branches 20622 20277 -345
===========================================
- Hits 76648 75333 -1315
+ Misses 34440 33930 -510
+ Partials 2610 2595 -15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
are you going to remove the v2 folder you had to create in a separated PR? |
Member
Author
yeah 😏 |
dougfabris
requested changes
Oct 3, 2025
dougfabris
approved these changes
Oct 6, 2025
debdutdeb
pushed a commit
that referenced
this pull request
Oct 7, 2025
juliajforesti
pushed a commit
that referenced
this pull request
Oct 8, 2025
juliajforesti
pushed a commit
that referenced
this pull request
Oct 8, 2025
This was referenced Oct 10, 2025
This was referenced Nov 6, 2025
This was referenced Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
VGA-6
Steps to test or reproduce
Further comments
Summary by CodeRabbit