Skip to content

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Sep 4, 2025

Proposed changes (including videos or screenshots)

Removes the livechat:transfer deprecated method
Removes the livechat/room.transfer deprecated endpoint
Creates the livechat/visitor.department.transfer since the suggested alternative of livechat/room.forward does not work with visitors authenticated with a visitor token (usually from the livechat client). So a new endpoint for department transfer was created for visitors

Issue(s)

ARCH-1755

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 4, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

🦋 Changeset detected

Latest commit: 4039b9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/ddp-client Major
@rocket.chat/livechat Major
@rocket.chat/rest-typings Major
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/ddp-streamer Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/http-router Patch
@rocket.chat/models Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/cron Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.39%. Comparing base (0d1c2a5) to head (4039b9d).
⚠️ Report is 4 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #36871      +/-   ##
=================================================
+ Coverage          66.01%   66.39%   +0.38%     
=================================================
  Files               3234     3312      +78     
  Lines             110445   111671    +1226     
  Branches           20638    20942     +304     
=================================================
+ Hits               72908    74145    +1237     
+ Misses             34926    34851      -75     
- Partials            2611     2675      +64     
Flag Coverage Δ
e2e 58.25% <ø> (+1.52%) ⬆️
unit 70.90% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo force-pushed the release-8.0.0 branch 3 times, most recently from e3a8829 to e19fae0 Compare September 4, 2025 19:01
@MartinSchoeler MartinSchoeler force-pushed the remove/livechat.room.transfer branch from 7816f67 to a14c9e1 Compare September 4, 2025 19:16
@MartinSchoeler MartinSchoeler force-pushed the remove/livechat.room.transfer branch from a14c9e1 to a1b02a8 Compare September 4, 2025 19:21
Copy link
Contributor

@lucas-a-pelegrino lucas-a-pelegrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, just out of curiosity, what was the reasoning behind changing the endpoint route from livechat/room.transfer to livechat/visitor.department.transfer?

@MartinSchoeler
Copy link
Member Author

Also, just out of curiosity, what was the reasoning behind changing the endpoint route from livechat/room.transfer to livechat/visitor.department.transfer?

To make it explicit that this endpoint is only available to visitors that have a token, not users, agents, or admins

@MartinSchoeler MartinSchoeler marked this pull request as ready for review September 9, 2025 18:57
@MartinSchoeler MartinSchoeler requested review from a team as code owners September 9, 2025 18:57
@MartinSchoeler MartinSchoeler added stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge labels Sep 11, 2025
@kodiakhq kodiakhq bot merged commit 5467e46 into release-8.0.0 Sep 11, 2025
41 checks passed
@kodiakhq kodiakhq bot deleted the remove/livechat.room.transfer branch September 11, 2025 19:26
gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants