-
Notifications
You must be signed in to change notification settings - Fork 13k
chore!: Remove deprecated livechat transfer method and endpoint
#36871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 4039b9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-8.0.0 #36871 +/- ##
=================================================
+ Coverage 66.01% 66.39% +0.38%
=================================================
Files 3234 3312 +78
Lines 110445 111671 +1226
Branches 20638 20942 +304
=================================================
+ Hits 72908 74145 +1237
+ Misses 34926 34851 -75
- Partials 2611 2675 +64
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
e3a8829 to
e19fae0
Compare
7816f67 to
a14c9e1
Compare
e19fae0 to
0d1c2a5
Compare
a14c9e1 to
a1b02a8
Compare
lucas-a-pelegrino
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, just out of curiosity, what was the reasoning behind changing the endpoint route from livechat/room.transfer to livechat/visitor.department.transfer?
To make it explicit that this endpoint is only available to visitors that have a token, not users, agents, or admins |
Proposed changes (including videos or screenshots)
Removes the
livechat:transferdeprecated methodRemoves the
livechat/room.transferdeprecated endpointCreates the
livechat/visitor.department.transfersince the suggested alternative oflivechat/room.forwarddoes not work with visitors authenticated with a visitor token (usually from the livechat client). So a new endpoint for department transfer was created for visitorsIssue(s)
ARCH-1755
Steps to test or reproduce
Further comments