Skip to content

Chore: Refactor other kinds of message - Phase 2#27927

Merged
ggazzo merged 9 commits into
developfrom
refactor/other-kinds-of-messages
Feb 4, 2023
Merged

Chore: Refactor other kinds of message - Phase 2#27927
ggazzo merged 9 commits into
developfrom
refactor/other-kinds-of-messages

Conversation

@tassoevan

@tassoevan tassoevan commented Feb 1, 2023

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Migrate "Starred Messages", "Pinned Messages", and "Mentions" from Blaze templates to React components.

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan force-pushed the refactor/other-kinds-of-messages branch 2 times, most recently from 54f2d84 to 7006e69 Compare February 1, 2023 22:18
@codecov

codecov Bot commented Feb 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #27927 (6cfbb02) into develop (81cee2e) will decrease coverage by 0.01%.
The diff coverage is 36.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27927      +/-   ##
===========================================
- Coverage    41.99%   41.98%   -0.01%     
===========================================
  Files          841      846       +5     
  Lines        17624    17545      -79     
  Branches      2071     2078       +7     
===========================================
- Hits          7401     7367      -34     
+ Misses        9945     9900      -45     
  Partials       278      278              
Flag Coverage Δ
e2e 41.98% <36.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/other-kinds-of-messages branch from 7006e69 to 0641c13 Compare February 3, 2023 14:44
@tassoevan tassoevan force-pushed the refactor/other-kinds-of-messages branch from 0641c13 to 3d0b33d Compare February 3, 2023 19:31
@tassoevan tassoevan marked this pull request as ready for review February 4, 2023 02:42
@tassoevan tassoevan requested review from a team as code owners February 4, 2023 02:42
@ggazzo ggazzo merged commit 15b76a0 into develop Feb 4, 2023
@ggazzo ggazzo deleted the refactor/other-kinds-of-messages branch February 4, 2023 04:08
gabriellsh added a commit that referenced this pull request Feb 6, 2023
….Chat into matrixSearch

* 'feat/federation-feat-2' of github.com:RocketChat/Rocket.Chat: (31 commits)
  fix: removing file wrongly merged on update merge
  [NEW] Federation search public rooms in the Matrix network (#27434)
  Chore: Refactor other kinds of message - Phase 2 (#27927)
  Chore: improve some e2e selectors (#27936)
  [NEW] Warning Popup reinforcing Zapier deprecation on Integrations Admin settings (#27744)
  Chore: Notify Marketplace on App Install (#27925)
  i18n: Language update from LingoHub 🤖 on 2023-01-23Z (#27814)
  [FIX][ENTERPRISE] DDP streamer sending data to destroyed streams (#27929)
  Chore: Migrate cached collections to TypeScript (#27909)
  i18n: Language update from LingoHub 🤖 on 2023-01-09Z (#27705)
  [FIX] Reduce re-subscription on `notify-room/user-activity` stream event (#27911)
  [FIX] Unread Message count not displayed for new messages in Omni-Rooms (#27539)
  Chore: Improve service's licence check (#27872)
  [IMPROVE] Livechat Persian translation (#27825)
  Chore(deps): Bump thehanimo/pr-title-checker from 1.3.4 to 1.3.6 (#27884)
  Chore: use useQuery in place of deprecated useEndpointData (#27673)
  Chore: Update Some Composer Icons (#27862)
  Regression: Undefined default message context (#27870)
  Chore: Remove OS version for device management (#27786)
  [BREAK] Remove less theming (#27647)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants