[FIX] New users aren't mapped to rooms with OAuth groups/channels map#27000
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #27000 +/- ##
===========================================
+ Coverage 40.52% 41.41% +0.89%
===========================================
Files 844 817 -27
Lines 17910 17391 -519
Branches 1988 1913 -75
===========================================
- Hits 7258 7203 -55
+ Misses 10396 9934 -462
+ Partials 256 254 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
suggested changes
Oct 31, 2022
5c5fe4b to
930c2cd
Compare
ae193fc to
5990323
Compare
matheusbsilva137
previously approved these changes
Nov 16, 2022
pierre-lehnen-rc
requested changes
Nov 21, 2022
pierre-lehnen-rc
left a comment
Contributor
There was a problem hiding this comment.
Change the federation.beforeAddUserAToRoom definition to list Inviter as optional, matching the definition of the addUserToRoom function.
…t/hooks/index.ts Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
Contributor
Author
this change it was already aligned with @MarcosSpessatto |
…nto fix/keycloak_oauth_channels_map
…RocketChat/Rocket.Chat into fix/keycloak_oauth_channels_map
…nto fix/keycloak_oauth_channels_map
17490f4 to
5eff5ef
Compare
MarcosSpessatto
suggested changes
Dec 16, 2022
MarcosSpessatto
approved these changes
Dec 16, 2022
The requested changes have been applied and approved by the Federation team
gabriellsh
added a commit
that referenced
this pull request
Dec 21, 2022
…discussion * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] E2EE initial banner not showing (#27574) Chore: Remove Sidebar from Blaze (#27571) Regression: Add tshow to composer params (#27602) [FIX] New users aren't mapped to rooms with OAuth groups/channels map (#27000) [NEW] New Message Composer (#27566) Chore: Fix homepage grid items style (#27527) Chore: TwoFactorPass Modals icon misalignment (#27591) Chore: Remove old tooltip usage (#26882) Bump version to 6.0.0-develop (#27598)
sampaiodiego
pushed a commit
that referenced
this pull request
Jan 24, 2023
…#27000) Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This change deals with the problem with the new users coming from key cloak, this users were not being mapped to the correct channels on RC.
Issue(s)
Steps to test or reproduce
Setup a KeyCloak VM and configure it on Rocketchat
(https://docs.google.com/document/d/1cBohJ1XrLm6vFIdBkEo8sr7xI2huEBE-sCCxcDibZU0/edit)
enable the setting to map users to channels and login on RC using keycloak, you should be redirected to a channel.
Further comments
TC-69