Regression: If Asterisk suddenly goes down, server has no way to know. Causes server to get stuck. Needs restart #24624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: This PR implements a connection retries in case the asterisk connection dies for some reason. It does 5 retries with backoff options. The retries will not be done for connectivity check. Once the retries are exhausted, and server comes up, there is no way to connect back but to restart the voip service. This works only for management connection. Call Server connection, if dies, there are no retries.
KevLehman
approved these changes
Feb 25, 2022
gabriellsh
added a commit
that referenced
this pull request
Feb 28, 2022
…age-template-2 * 'develop' of github.com:RocketChat/Rocket.Chat: (61 commits) Regression: Server crashing if Voip credentials are invalid (#24646) Regression: Extension List panel UI not aligned with designs (#24645) Regression: Queue counter aggregator for incoming/hanged calls (#24635) Regression: Fix double value on holdTime and empty msg on last message (#24630) Regression: If Asterisk suddenly goes down, server has no way to know. Causes server to get stuck. Needs restart (#24624) Regression: Prevent connect to asterisk when VoIP is disabled (#24601) Regression: Encode registration info as JWT when signing key is provided (#24626) Regression: Fix time fields and wrap up in Voip Room Contexual bar (#24625) Regression: Fix in-correct room status shown to agents (#24592) Regression: Do not show toast on incoming voip calls (#24619) Regression: Fix incoming voip call ringtone is not ringing (#24616) Regression: Mark all rooms as read modal closing instantly. (#24610) Regression: Fix translations for call started message (#24615) Regression: Bunch of settings fixes for VoIP (#24594) Regression: Admin Sidebar colors inverted (#24609) Regression: No audio when call comes from Skype/IP phone (#24602) Regression: Fixes in Voice Contextual Bar and Directory (#24596) Regression: Fix time format on Voip system messages (#24603) Regression: VoIP service button displayed when VoIP is disabled (#24598) Add support to namespace within micro services (#24581) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR implements a connection retries in case the asterisk connection dies for some reason.
It does 5 retries with backoff options. The retries will not be done for connectivity check.
Once the retries are exhausted, and server comes up, there is no way to connect back but to restart
the voip service. This works only for management connection. Call Server connection, if dies, there are no
retries.
Issue(s)
https://app.clickup.com/t/22qmrw3
Steps to test or reproduce
APIs get stuck as server does not check if the socket is up while running a command.
After this PR is merged, server will return error if the connection is dead. It will also retry to connect after detecting disconnection
Further comments