[FIX] Omnichannel managers can't join chats in progress #24553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtaza98
added a commit
that referenced
this pull request
Feb 21, 2022
Contributor
|
Hi @renatobecker Thanks for this fix 🙌 I added some of my suggestions within this PR #24557 . It's mainly for converting the meteor method to API. Apart from these minor suggestions, this PR looks perfect to me!! |
Merged
KevLehman
pushed a commit
that referenced
this pull request
Apr 12, 2022
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
sampaiodiego
pushed a commit
that referenced
this pull request
Apr 12, 2022
Co-authored-by: Murtaza Patrawala <34130764+murtaza98@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Monitor|Manager can't join the actual chat by pressing the "Take It" button.
recordedVideo.mp4
Steps to test or reproduce
Expected Behavior:
Be able to join the chat either taking it or joining it.
Actual Behavior:
A warning says "Not permitted" after clicking the button
Further comments
In order to fix the issue reactivity improvements have been added, also a new UI for chats already in progress:
In case managers/monitors need to join a chat in progress taken by another agent, they will see a
Joinbutton. This new UX will not just add the user to the room but also check specific rules before joining, such as Max. number of simultaneous chats in progress.