[FIX] MAU when using micro services #24204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging c7d7bb6 into 6e16ba8 - view on LGTM.com new alerts:
|
ggazzo
requested changes
Jan 19, 2022
Comment on lines
327
to
333
| await aggregates.dailySessionsOfYesterday(Sessions.col, yesterday).forEach(async (record) => { | ||
| await Sessions.updateOne( | ||
| { _id: `${record.userId}-${record.year}-${record.month}-${record.day}` }, | ||
| { $set: record }, | ||
| { upsert: true }, | ||
| ); | ||
| }); |
Member
There was a problem hiding this comment.
Suggested change
| await aggregates.dailySessionsOfYesterday(Sessions.col, yesterday).forEach(async (record) => { | |
| await Sessions.updateOne( | |
| { _id: `${record.userId}-${record.year}-${record.month}-${record.day}` }, | |
| { $set: record }, | |
| { upsert: true }, | |
| ); | |
| }); | |
| await aggregates.dailySessionsOfYesterday(Sessions.col, yesterday).map(async (record) => Sessions.updateOne( | |
| { _id: `${record.userId}-${record.year}-${record.month}-${record.day}` }, | |
| { $set: record }, | |
| { upsert: true }, | |
| )); |
Comment on lines
80
to
82
| onClose: (fn): void => { | ||
| this.on('close', fn); | ||
| }, |
Member
There was a problem hiding this comment.
maybe we should check if this is intended, looks more a leak but not sure
ggazzo
approved these changes
Jan 19, 2022
gabriellsh
added a commit
that referenced
this pull request
Jan 19, 2022
…hat into improve/setup-wizard * 'improve/setup-wizard' of github.com:RocketChat/Rocket.Chat: Regression: Fix handling of http requests in apps bridge (#24211) Bump version to 4.3.2 [FIX] Integration section crashing opening in My Account (#24068) Chore: Update Apps-Engine to 1.29.2 (#24171) [FIX] App Framework Enable hanging indefinitely (#24158) [FIX] CSV Importer failing to import users (#24090) Fix Engagement Dashboard API requests (#24142) [FIX] MAU when using micro services (#24204) [IMPROVE] Limit recent emojis to 27 (#24210) Bump version to 4.3.1 Bump Fuselage packages [FIX][APPS] Action buttons not removed when app is disabled or uninstalled (#24107) [FIX][APPS] Prevents emails from being sent when apps framework is disabled (#24105) [FIX] Ensure Firefox 91 ESR support (#24096) Chore: Update Livechat (#24091) [FIX] Omnichannel enabled setting not working when creating rooms (#24067) [FIX] Enter not working on modal's multi-line input (#23981) [FIX] Omnichannel Current chats pagination not working (#24039)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments