Skip to content

[IMPROVE] Throw 404 error in invalid endpoints #24053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matheusbsilva137 merged 6 commits into from
Dec 30, 2021
Merged

[IMPROVE] Throw 404 error in invalid endpoints #24053

matheusbsilva137 merged 6 commits into from
Dec 30, 2021

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Dec 29, 2021

Proposed changes (including videos or screenshots)

  • Throw 404 error when trying to call invalid endpoints.

Issue(s)

Steps to test or reproduce

Expected output to an invalid endpoint:

{
  "statusCode": 404,
  "body": {
    "success": false,
    "error": "Resource not found"
  }
}

Further comments

sampaiodiego
sampaiodiego previously requested changes Dec 29, 2021
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix new eslint/prettier rules 😬

@matheusbsilva137 matheusbsilva137 dismissed sampaiodiego’s stale review December 30, 2021 19:58

Reviewed by Pierre + went through QA

@matheusbsilva137 matheusbsilva137 merged commit b22192f into develop Dec 30, 2021
@matheusbsilva137 matheusbsilva137 deleted the improve/api-404 branch December 30, 2021 19:58
matheusbsilva137 added a commit that referenced this pull request Jan 6, 2022
@matheusbsilva137
Revert "[IMPROVE] Throw 404 error in invalid endpoints (#24053)"
bb734ce 
This reverts commit b22192f.
@matheusbsilva137 matheusbsilva137 mentioned this pull request Jan 6, 2022
Merged
@d-gubert d-gubert mentioned this pull request Jan 9, 2022
Closed
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierre-lehnen-rc pierre-lehnen-rc pierre-lehnen-rc approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matheusbsilva137 @sampaiodiego @pierre-lehnen-rc