Chore: Fix i18n duplicated keys#19998
Merged
Merged
Conversation
ggazzo
approved these changes
Dec 30, 2020
gabriellsh
added a commit
that referenced
this pull request
Jan 4, 2021
…info_page * 'develop' of github.com:RocketChat/Rocket.Chat: (255 commits) Chore: Add tests for the api/licenses.* endpoints (#20041) Language update from LingoHub 🤖 on 2021-01-04Z (#20034) [FIX] Omnichannel Agents unable to take new chats in the queue (#20022) [FIX] Omnichannel Business Hours form is not being rendered (#20007) Language update from LingoHub 🤖 (#20013) Chore: Fix i18n duplicated keys (#19998) [FIX] Agent information panel not rendering (#19965) [FIX] Apps Create Room method with agent not working (#19997) Chore: add tests to api/instances.get endpoint (#19988) Bump version to 3.11.0-develop Bump version to 3.10.0 Bump version to 3.10.0-rc.4 Bump version to 3.10.0-rc.3 Bump version to 3.10.0-rc.2 Bump version to 3.10.0-rc.1 Bump version to 3.10.0-rc.0 Revert "[NEW] Storj integration (#19932)" Regression: polishing licenses endpoints (#19981) Regression: Double Scrollbars on tables (#19980) Regression: Add currently running instance to instances.get endpoint (#19955) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
LingoHub doesn't like duplicated keys on JSON files, which cause an import to fail, making things not being synced, so I'm adding a validation of duplicated keys to prevent that from happen again.
Issue(s)
Steps to test or reproduce
Further comments