feat: add support for nodejs-wheel#299
Merged
RobertCraigie merged 4 commits intomainfrom Sep 22, 2024
Merged
Conversation
1201746 to
bb4d97e
Compare
45406a9 to
179cc30
Compare
179cc30 to
d221beb
Compare
d221beb to
407f2a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can now run the following command to automatically download Node.js binaries at install-time, circumventing the flakiness that occurs with
nodeenv.This takes us one step further towards a
pip install pyrightthat actuals installs all the necessary files.Partially resolves #231