-
Notifications
You must be signed in to change notification settings - Fork 24
bundle node and pyright with the pypi package #231
Copy link
Copy link
Description
having the pypi package download both node and the npm package when you first run the pyright command causes some issues:
- we have a docker image where all the dependencies are installed, but when the pyright job runs in our CI, it can fail because the runner cannot access npm (due to corporate proxy nonsense). to work around this, we had to put this command in our dockerfile:
# installs node & pyright RUN pyright --version
- Pre-commit install hook doesn't actually install Pyright #225
- npm is incredibly slow and unreliable on PCs at my work
i think bundling the npm package and node in the pypi package would be a much more reliable solution. that's how the playwright pypi package works for example
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels