Skip to content

Internal class reflections#80

Merged
Ocramius merged 30 commits intomasterfrom
internal-class-reflections
Jul 22, 2015
Merged

Internal class reflections#80
Ocramius merged 30 commits intomasterfrom
internal-class-reflections

Conversation

@asgrim
Copy link
Copy Markdown
Member

@asgrim asgrim commented Jul 20, 2015

This PR fixes #38

  • AggregateSourceLocators can be nested now (Reflector\Generic will recurse through them in a flat ordered way)
  • I had to modify the behaviour of the SourceLocators slightly so that they don't throw exceptions, but merely return null. This is so that when we loop through the AggregateSourceLocator, we don't break the loop.
  • By default PhpInternalSourceLocator gets added to all calls to reflect(). Can be disabled by a paramter
  • A new magic const is defined as a flag to notify ReflectionClass that the LocatedSource originated from the PhpInternalSourceLocator (thus isInternal() === true)

Todo

  • Needs the rest of the internal classes implemented...
  • ~~~Need to implement functions too...~~~
  • More path coverage for PhpInternalSourceLocator

@asgrim asgrim self-assigned this Jul 20, 2015
@asgrim asgrim added this to the 1.0.0 milestone Jul 20, 2015
Ocramius
Ocramius reviewed Jul 21, 2015
View reviewed changes
src/SourceLocator/AggregateSourceLocator.php
Copy link
Copy Markdown
Member

@Ocramius Ocramius Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just if ($sourceLocator instanceof Traversable) {?

Copy link
Copy Markdown
Member Author

@asgrim asgrim Jul 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'cuz AggregateSourceLocator is not Traversable?

Ocramius added 18 commits July 22, 2015 00:22
@Ocramius
Documenting constructor parameters
73ac4bd
@Ocramius
CompileNodeToValue should consider negative values as well
c8f2f54
@Ocramius
Handling negative values in CompileNodeToValue
336d9aa
@Ocramius
Upgrading to PHP7-compatible parser by @nikic because #yolo
4439ef4
@Ocramius
Initial testing: internal reflector MUST support internal classes ref…
ed43548 
…lection
@Ocramius
Initial implementation of a source locator capable of stubbing intern…
f429f19 
…als code
@Ocramius
Specification for InternalLocatedSource
eaeb8d7
@Ocramius
Implementing EvaledLocatedSource
eaf6712
@Ocramius
Accurately testing the internal source locator - all internal classes…
c8c5758 
… should be reflectable and produce an InternalLocatedSource
@Ocramius
Removing useless hint
d297cbb
@Ocramius
Internal sources shalt be internal sources forever
fff7c18
@Ocramius
The internal source locator should retrieve InternalLocatedSource i…
08b7da5 
…nstances when producing a result
@Ocramius
LocatedSource#isEvaled() specification
b29dd2a
@Ocramius
isEvaled base implementation, removing clutter that isn't needed
9625c98
@Ocramius
EvaledLocatedSource implementation and tests
5800109
@Ocramius
Correcting SUT class
b92828d
@Ocramius
Basic EvaledCodeSourceLocator implementation
9e56d5f
@Ocramius
Testing evaluation of eval()'d source classes
745408b
@Ocramius Ocramius changed the title [WIP] Internal class reflections Internal class reflections Jul 22, 2015
Ocramius added a commit that referenced this pull request Jul 22, 2015
@Ocramius
Merge pull request #80 from Roave/internal-class-reflections
a5bcb25 
Internal class reflections
@Ocramius Ocramius merged commit a5bcb25 into master Jul 22, 2015
@Ocramius Ocramius deleted the internal-class-reflections branch July 22, 2015 00:58
This was referenced Jul 26, 2015
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@asgrim asgrim

Labels

reflection compatibility

Projects

None yet

Milestone

0.1.0

Development

Successfully merging this pull request may close these issues.

Create ReflectionFunctions/ReflectionClasses from internal definitions

2 participants

@asgrim @Ocramius