Skip to content

Compatibility for ReflectionClass#59

Merged
Ocramius merged 88 commits intomasterfrom
compat-reflectionclass
Jul 20, 2015
Merged

Compatibility for ReflectionClass#59
Ocramius merged 88 commits intomasterfrom
compat-reflectionclass

Conversation

@asgrim
Copy link
Copy Markdown
Member

@asgrim asgrim commented Jul 12, 2015

This PR brings about "most" compatibility for ReflectionClass, thus merging this will finally resolve #7.

General

  • Rebase onto master before merge (Update CS rules #60 may cause conflict)
  • getParentClass
  • getDefaultProperties
  • getDocComment
  • getStartLine
  • getEndLine
  • hasConstant
  • hasMethod
  • hasProperty
  • isInternal
  • isUserDefined
  • isAbstract
  • isFinal
  • getModifiers

Trait-related

Interface-related

  • getInterfaceNames
  • getInterfaces
  • isInterface

Needs parent/interface/trait hierarchy

  • isCloneable
  • isInstance
  • isInstantiable
  • isIterateable
  • isSubClassOf
  • implementsInterface

Other stuff

  • Inject BetterReflection\Reflector\Reflector instead of a SourceLocator to things like getTraits, getInterfaces, getParentClass (and other related methods)

@asgrim asgrim added this to the 1.0.0 milestone Jul 12, 2015
@asgrim asgrim self-assigned this Jul 12, 2015
This was referenced Jul 12, 2015
Closed
Closed
@asgrim asgrim force-pushed the compat-reflectionclass branch 3 times, most recently from c8f6304 to f2d54d9 Compare July 14, 2015 16:33
@asgrim asgrim mentioned this pull request Jul 15, 2015
Merged
asgrim added 17 commits July 15, 2015 13:36
@asgrim
Added ReflectionClass->getParentClass() method
7f637e6
@asgrim
Added ReflectionClass::getStartLine and ::getEndLine methods
125d4ec
@asgrim
Added ReflectionClass::getDocComment
ee7d61e
@asgrim
Added ReflectionMethod ::hasProperty ::hasConstant and ::hasMethod
b9ca57b
@asgrim
Added ReflectionClass::getDefaultProperties() method
08ba965
@asgrim
Added ReflectionClass::isInternal and ::isUserDefined methods
94350c8
@asgrim
Added ReflectionClass ::isFinal and ::isAbstract
72a763f
@asgrim
Added ReflectionClass::getModifiers() method
6ca1085
@asgrim
Implemented ReflectionClass::isTrait()
22b72f6
@asgrim
Added ReflectionClass::isInterface() method
bb2fada
@asgrim
Add a type check to isFinal() and isAbstract()
55ebd7f
@asgrim
Added ReflectionClass::getTraits() method
4ea1003
@asgrim
Added private methods getFqsenFromNamedNode and reflectClassForNamedN…
af3e6fd 
…ode helper methods for internally reconstructing traits and interfaces
@asgrim
Expanded the TraitFixture for tests
0189f6b
@asgrim
Added ReflectionClass->getTraitNames() method
c518e58
@asgrim
comma
d020f3e
@asgrim
Implement ReflectionClass::getTraitAliases() using proposed phpDocume…
6771a39 
…ntor/TypeResolver PR
Ocramius
Ocramius reviewed Jul 17, 2015
View reviewed changes
src/Reflection/ReflectionClass.php Outdated
Copy link
Copy Markdown
Member

@Ocramius Ocramius Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string

Ocramius and others added 23 commits July 20, 2015 15:56
@Ocramius
Abstract extensions/implementations of Traversable should not be it…
ac34547 
…eratable
@Ocramius
Only instantiable Traversable should be iteratable
e3cbb74
@Ocramius
Complex interface inheritance examples
6a0e9cb
@Ocramius
Fetched interfaces should include parent interfaces of implemented in…
45f416d 
…terface
@Ocramius
CS (spacing)
9dddc70
@Ocramius
Implementing code to switch between fetching parent interfaces for cl…
af90c9a 
…asses or nodes
@Ocramius
Removing NoParent throwing annotation docblock
0464f60
@Ocramius
Add TODO about the possibility of throwing an exception when an inval…
bf73028 
…id inheritance tree is encountered
@Ocramius
Removing useless looping operations (splat already handles everything)
4f22539
@Ocramius
Implementing NotAClassReflection exception (tested)
8873ee3
@Ocramius
NotAnInterfaceReflection exception with tests
50b077d
@Ocramius
Invalid fixtures to test cases where incorrect inheritances are refle…
6465588 
…cted
@Ocramius
Invalid class: class extending a trait
e2b765e
@Ocramius
Reflecting the parent class of a class that extends from an interface…
c7b86f2 
… should lead to a failure
@Ocramius
Reflecting the parent class of a class that extends from a trait shou…
6669436 
…ld lead to a failure
@Ocramius
Reflecting the parent interfaces of an interface that extends from a …
7015f81 
…class should lead to a failure
@Ocramius
Test asset: interface extending a trait (invalid)
08d3f31
@Ocramius
Correcting tests, interfaces extending from traits to be considered i…
dabcc7e 
…nvalid (throwing an exception)
@Ocramius
Implementing logic to prevent silently reflecting invalid parent clas…
f0da2e1 
…s/interface
@asgrim
Merge pull request #77 from Roave/feature/compat-reflectionclass-isin…
886b1a7 
…stantiable

`ReflectionClass#isInstantiable()`, `ReflectionClass#isCloneable()`, `ReflectionClass#isIterateable()` and fixes to `ReflectionClass#getInterfaces()` based on multiple inheritance in interfaces
@Ocramius
Source locator shouldn't be needed anymore when reflecting associated…
5653966 
… reflection objects
@Ocramius
Removing source locator requirement from ReflectionClass - now simp…
fd1808d 
…ly uses the passed in reflector every time
@asgrim
Merge pull request #79 from Roave/hotfix/source-locator-parameter-rem…
8c541ba 
…oval

Source locator parameter removal when traversing reflection objects
@asgrim asgrim changed the title [WIP] Compatibility for ReflectionClass Compatibility for ReflectionClass Jul 20, 2015
@asgrim asgrim assigned Ocramius and unassigned asgrim Jul 20, 2015
Ocramius added a commit that referenced this pull request Jul 20, 2015
@Ocramius
Merge pull request #59 from Roave/compat-reflectionclass
396c35d 
Compatibility for ReflectionClass
@Ocramius Ocramius merged commit 396c35d into master Jul 20, 2015
@Ocramius Ocramius deleted the compat-reflectionclass branch July 20, 2015 18:18
@asgrim asgrim mentioned this pull request Jul 26, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

reflection compatibility

Projects

None yet

Milestone

0.1.0

Development

Successfully merging this pull request may close these issues.

Need to become "mostly" compatible with PHP's Reflection API

2 participants

@asgrim @Ocramius