Skip to content

Implement [g|s]etStaticPropertyValue in ReflectionClass#114

Merged
Ocramius merged 4 commits intomasterfrom
implement-accessors
Jan 30, 2016
Merged

Implement [g|s]etStaticPropertyValue in ReflectionClass#114
Ocramius merged 4 commits intomasterfrom
implement-accessors

Conversation

@asgrim
Copy link
Copy Markdown
Member

@asgrim asgrim commented Aug 28, 2015

As part of issue #14, this implements some stuff that requires the class to be loaded that we do not previously implement.

  • getStaticPropertyValue
  • setStaticPropertyValue

@asgrim asgrim self-assigned this Aug 28, 2015
@asgrim asgrim added this to the 1.0.0 milestone Aug 28, 2015
Ocramius
Ocramius reviewed Aug 31, 2015
View reviewed changes
src/Reflection/ReflectionClass.php Outdated
Copy link
Copy Markdown
Member

@Ocramius Ocramius Aug 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar issue here

@asgrim asgrim force-pushed the implement-accessors branch from 337f7c4 to e8571ad Compare September 7, 2015 16:26
@asgrim asgrim assigned Ocramius and unassigned asgrim Sep 7, 2015
@asgrim asgrim changed the title [WIP] Implement some class-loaded-requiring stuff Implement some class-loaded-requiring stuff Sep 7, 2015
@asgrim asgrim mentioned this pull request Sep 7, 2015
Closed
11 tasks
@asgrim asgrim changed the title Implement some class-loaded-requiring stuff Implement [g|s]etStaticPropertyValue in ReflectionClass Sep 7, 2015
@asgrim asgrim force-pushed the implement-accessors branch from e8571ad to 75c075c Compare September 23, 2015 08:23
@asgrim asgrim force-pushed the implement-accessors branch from 75c075c to 9ca05a6 Compare October 28, 2015 20:31
@asgrim asgrim modified the milestones: 1.1.0, 1.0.0 Nov 2, 2015
@asgrim asgrim force-pushed the implement-accessors branch from 9ca05a6 to bebcdbc Compare November 5, 2015 15:15
@asgrim asgrim force-pushed the implement-accessors branch from bebcdbc to 7b4e8fe Compare November 26, 2015 17:14
@asgrim asgrim force-pushed the implement-accessors branch from 7b4e8fe to 1841e0f Compare January 7, 2016 00:22
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Jan 26, 2016

@asgrim this looks 👍, but needs a rebase

@asgrim asgrim force-pushed the implement-accessors branch from 1841e0f to b7a1cbc Compare January 30, 2016 10:50
@asgrim
Copy link
Copy Markdown
Member Author

asgrim commented Jan 30, 2016

@Ocramius rebase done

Ocramius added a commit that referenced this pull request Jan 30, 2016
@Ocramius
Merge pull request #114 from Roave/implement-accessors
f2706b5 
Implement [g|s]etStaticPropertyValue in ReflectionClass
@Ocramius Ocramius merged commit f2706b5 into master Jan 30, 2016
@Ocramius Ocramius deleted the implement-accessors branch January 30, 2016 10:56
@Ocramius
Copy link
Copy Markdown
Member

Ocramius commented Jan 30, 2016

@asgrim 👍

@asgrim asgrim mentioned this pull request Feb 4, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ocramius Ocramius

Labels

reflection compatibility

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asgrim @Ocramius