Secret callback#1
Closed
JacoKoster wants to merge 18 commits intoRichie765:secret-callbackfrom
JacoKoster:secret-callback
Closed
Secret callback#1JacoKoster wants to merge 18 commits intoRichie765:secret-callbackfrom JacoKoster:secret-callback
JacoKoster wants to merge 18 commits intoRichie765:secret-callbackfrom
JacoKoster:secret-callback
Conversation
* add newer node versions to build matrix * Dont test for node 9 Its not stable and seems to fail on travis
This option allows you to keep a reference to the raw token payload after claims have been applied to it but before it has been encoded.
It does kinda go without saying that JWTs (_JSON_ Web Tokens) need to contain JSON but it's worth mentioning that signing doesn't check your payload. In some unit tests I was writing where the payload was a dummy (non-JSON parsable) string, JWTs were being signed okay but they're not valid according to the spec.
* Check payload is not null when decoded. Fixed "Cannot read property 'nbf' of null" * Condition on obj !== null for clarity * Added test for decoding null token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two missing tests and checked coverage, it should be ok now.