Bump ms version to add support for negative numbers#438
Merged
ziluvatar merged 1 commit intoauth0:masterfrom Jan 19, 2018
MitMaro:bump-ms
Merged
Bump ms version to add support for negative numbers#438ziluvatar merged 1 commit intoauth0:masterfrom MitMaro:bump-ms
ziluvatar merged 1 commit intoauth0:masterfrom
MitMaro:bump-ms
Conversation
ziluvatar
approved these changes
Jan 19, 2018
Contributor
|
Thanks @MitMaro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
zeit/ms@2.1.1added full support for negative numbers, but the package is set tozeit/ms@2.0.0. This can be useful when defining anbfvalue withzeit/ms, ie.nbf = '-30m'.Due to npm's dependency de-duping this can sometimes result in this library using version
zeit/ms@2.0.0instead ofzeit/ms@2.1.1resulting in invalid results. In my casevisionmedia/debughad their version onzeit/mspinned to2.0.0.This PR bumps the version to
zeit/ms@2.1.1to ensure that negative numbers inzeit/msformat work as expected.Dedupe Example