Skip to content

Bump ms version to add support for negative numbers#438

Merged
ziluvatar merged 1 commit intoauth0:masterfrom
MitMaro:bump-ms
Jan 19, 2018
Merged

Bump ms version to add support for negative numbers#438
ziluvatar merged 1 commit intoauth0:masterfrom
MitMaro:bump-ms

Conversation

@MitMaro
Copy link
Copy Markdown
Contributor

@MitMaro MitMaro commented Jan 11, 2018

What

zeit/ms@2.1.1 added full support for negative numbers, but the package is set to zeit/ms@2.0.0. This can be useful when defining a nbf value with zeit/ms, ie. nbf = '-30m'.

Due to npm's dependency de-duping this can sometimes result in this library using version zeit/ms@2.0.0 instead of zeit/ms@2.1.1 resulting in invalid results. In my case visionmedia/debug had their version on zeit/ms pinned to 2.0.0.

This PR bumps the version to zeit/ms@2.1.1 to ensure that negative numbers in zeit/ms format work as expected.

Dedupe Example

$ npm show ms version
2.1.1

$ npm list ms
@org/auth-lib@1.0.0 /Users/mitmaro/code/org/auth-lib
├─┬ debug@3.1.0
│ └── ms@2.0.0
└─┬ jsonwebtoken@8.1.0
  └── ms@2.0.0  deduped

@ziluvatar ziluvatar merged commit 25e0e62 into auth0:master Jan 19, 2018
@ziluvatar
Copy link
Copy Markdown
Contributor

Thanks @MitMaro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants