fix(orchestrator): route General topic in forum groups#110
Merged
RichardAtCT merged 1 commit intoRichardAtCT:mainfrom Feb 26, 2026
Merged
fix(orchestrator): route General topic in forum groups#110RichardAtCT merged 1 commit intoRichardAtCT:mainfrom
RichardAtCT merged 1 commit intoRichardAtCT:mainfrom
Conversation
Telegram omits `message_thread_id` for messages in the built-in General topic of forum supergroups, causing `_extract_message_thread_id` to return None. The routing guard then rejects these messages. Default to thread ID 1 (Telegram's canonical General topic ID) when no thread ID is present and the chat is a forum group. Closes #109
RichardAtCT
added a commit
that referenced
this pull request
Feb 26, 2026
MagicMock auto-creates attributes on access, so getattr(mock, "is_forum", False) returns a truthy MagicMock instead of False. The new forum detection in _extract_message_thread_id incorrectly treated test mocks as forum chats.
This was referenced Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message_thread_idfor messages in the built-in General topic of forum supergroups_extract_message_thread_idreturnsNone, so the routing guard rejects these messages1(Telegram's canonical General topic ID) when the chat is a forum group and no thread ID is presentCloses #109
Test plan
PROJECT_THREADS_MODE=groupNone)🤖 Generated with Claude Code