Make hotfixes not deploy with the latest tag nor update latest docs#937
Merged
tonidero merged 4 commits intoMar 12, 2024
Merged
Conversation
tonidero
commented
Mar 11, 2024
| lane :release do |options| | ||
| version_number = current_version_number | ||
| is_prerelease = Gem::Version.new(version_number).prerelease? | ||
| is_hotfix = !is_prerelease ? hotfix?(package_name) : false |
Contributor
Author
There was a problem hiding this comment.
Note that I'm only checking the version for the base package, not for the paywalls package. So this assumes they will always have the same version and be deployed one after another.
| 'publish', | ||
| is_prerelease ? '--tag next' : nil | ||
| is_prerelease ? '--tag next' : nil, | ||
| is_hotfix ? '--tag hotfix' : nil, |
Contributor
Author
There was a problem hiding this comment.
I thought about reusing the same tag (next) but didn't feel right...
Contributor
Author
|
What do you think about this approach? If we like it, I can move it to the other places we publish to npm/docs like this. |
joshdholtz
approved these changes
Mar 11, 2024
vegaro
approved these changes
Mar 11, 2024
| def hotfix?(package_name) | ||
| last_published_version = sh("npm", "view", package_name, "version") | ||
| Gem::Version.new(current_version_number) < Gem::Version.new(last_published_version) | ||
| end |
This was referenced Mar 13, 2024
vegaro
pushed a commit
that referenced
this pull request
Mar 14, 2024
**This is an automatic release.** ### New Features * Add `displayCloseButton` option to `PaywallView` (#913) via Cesar de la Vega (@vegaro) ### Dependency Updates * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.2.0 (#940) via RevenueCat Git Bot (@RCGitBot) * [Android 7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2) * [iOS 4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0) * [iOS 4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1) * [iOS 4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0) * [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.1.0 (#938) via RevenueCat Git Bot (@RCGitBot) * [Android 7.7.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.7.2) * [iOS 4.39.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.39.0) * [iOS 4.38.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.1) * [iOS 4.38.0](https://github.com/RevenueCat/purchases-ios/releases/tag/4.38.0) ### Other Changes * Make hotfixes not deploy with the latest tag nor update latest docs (#937) via Toni Rico (@tonidero) * Update RELEASING.md (#936) via Cesar de la Vega (@vegaro) * Add 6.7.2 to changelog (#935) via Cesar de la Vega (@vegaro) --------- Co-authored-by: RevenueCat CI <dev+ci@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing hotfixes, our automations don't work great since they may actually publish as the latest version, overriding the latest package + the default package our docs point to. This fixes that so if we detect that the current version is older than the version