Skip to content

Require PR approval before release tagging#1685

Merged
ajpallares merged 2 commits into
mainfrom
pallares/require-release-pr-approval
Mar 23, 2026
Merged

Require PR approval before release tagging#1685
ajpallares merged 2 commits into
mainfrom
pallares/require-release-pr-approval

Conversation

@ajpallares

@ajpallares ajpallares commented Mar 20, 2026

Copy link
Copy Markdown
Member

Motivation

The release workflow currently allows tagging a release branch without verifying that the PR has been reviewed and approved. This adds a safeguard to ensure the release PR is properly approved before the tag is created.

Description

Bumps revenuecat/sdks-common-config orb to @3.16.0, which includes a validate_pr_approved step in the tag-current-branch job. This verifies the release PR has been approved by an org member with write permissions before the git tag is created.

Depends on: RevenueCat/sdks-circleci-orb#41

@ajpallares ajpallares added the pr:other A code change that improves performance label Mar 20, 2026
This version includes a `validate_pr_approved` check in `tag-current-branch`
that verifies the release PR has been approved before the tag is created.

Made-with: Cursor
@ajpallares ajpallares force-pushed the pallares/require-release-pr-approval branch from 395aff1 to 38842b9 Compare March 20, 2026 17:42
@ajpallares ajpallares marked this pull request as ready for review March 23, 2026 11:24
@ajpallares ajpallares requested a review from a team as a code owner March 23, 2026 11:24
@ajpallares ajpallares merged commit 1a0d852 into main Mar 23, 2026
8 checks passed
@ajpallares ajpallares deleted the pallares/require-release-pr-approval branch March 23, 2026 11:43
This was referenced Mar 25, 2026
RCGitBot added a commit that referenced this pull request Mar 27, 2026
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* CustomerCenter: Adds onPromotionalOfferSucceeded callback, bump
purchases-hybrid-common to 17.53.0 (#1684) via RevenueCat Git Bot
(@RCGitBot)
* [Android
9.27.0](https://github.com/RevenueCat/purchases-android/releases/tag/9.27.0)
* [iOS
5.66.0](https://github.com/RevenueCat/purchases-ios/releases/tag/5.66.0)
### 📦 Dependency Updates
* [RENOVATE] Update dependency gradle to v9.4.1 (#1688) via RevenueCat
Git Bot (@RCGitBot)

### 🔄 Other Changes
* Bump node-forge from 1.3.3 to 1.4.0 (#1700) via dependabot[bot]
(@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `9a6911b` to `f11fe40`
(#1699) via dependabot[bot] (@dependabot[bot])
* Bump yaml from 1.10.2 to 1.10.3 (#1695) via dependabot[bot]
(@dependabot[bot])
* Bump yaml from 2.8.2 to 2.8.3 in /examples/MagicWeather (#1698) via
dependabot[bot] (@dependabot[bot])
* Bump picomatch from 2.3.1 to 2.3.2 (#1697) via dependabot[bot]
(@dependabot[bot])
* Bump picomatch from 2.3.1 to 2.3.2 in /examples/MagicWeather (#1696)
via dependabot[bot] (@dependabot[bot])
* Bump activesupport from 7.2.2.1 to 7.2.3.1 in
/examples/purchaseTesterTypescript (#1693) via dependabot[bot]
(@dependabot[bot])
* Bump fast-xml-parser from 4.5.4 to 4.5.5 in /examples/MagicWeather
(#1692) via dependabot[bot] (@dependabot[bot])
* security: pin GitHub Actions to SHA hashes (#1691) via Alfonso
Embid-Desmet (@alfondotnet)
* Bump activesupport from 7.2.2.2 to 7.2.3.1 (#1690) via dependabot[bot]
(@dependabot[bot])
* Bump activesupport from 7.2.2.1 to 7.2.3.1 in /examples/MagicWeather
(#1689) via dependabot[bot] (@dependabot[bot])
* Merge release PR after deploy (#1686) via Antonio Pallares
(@ajpallares)
* Require PR approval before release tagging (#1685) via Antonio
Pallares (@ajpallares)
* Bump flatted from 3.3.3 to 3.4.2 in /examples/MagicWeather (#1687) via
dependabot[bot] (@dependabot[bot])
* Bump json from 2.18.1 to 2.19.2 (#1683) via dependabot[bot]
(@dependabot[bot])

---------

Co-authored-by: RevenueCat CI <dev+ci@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:other A code change that improves performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants