Skip to content

Add offeringId override to trackCustomPaywallImpression#1679

Merged
rickvdl merged 1 commit into
mainfrom
rickvdl/custom-paywall-impression-offering-id-override
Mar 18, 2026
Merged

Add offeringId override to trackCustomPaywallImpression#1679
rickvdl merged 1 commit into
mainfrom
rickvdl/custom-paywall-impression-offering-id-override

Conversation

@rickvdl

@rickvdl rickvdl commented Mar 18, 2026

Copy link
Copy Markdown
Member

Summary

  • Add optional offeringId parameter to TrackCustomPaywallImpressionOptions
  • If not provided, the SDK uses the current offering identifier from the cache
  • Update purchase tester demo screen with text fields for both paywall ID and offering ID

Related PRs

@rickvdl rickvdl added the pr:feat A new feature label Mar 18, 2026
@rickvdl rickvdl marked this pull request as ready for review March 18, 2026 07:19
@rickvdl rickvdl requested a review from a team as a code owner March 18, 2026 07:19

@ajpallares ajpallares left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@rickvdl rickvdl force-pushed the rickvdl/custom-paywall-impression-offering-id-override branch from 912f952 to 8834d82 Compare March 18, 2026 08:19
rickvdl added a commit to RevenueCat/purchases-unity that referenced this pull request Mar 18, 2026
## Summary
- Add optional `OfferingId` parameter to `CustomPaywallImpressionParams`
- If not provided, the SDK uses the current offering identifier from the
cache
- Update Subtester with offering ID text field

## Related PRs
- purchases-hybrid-common:
RevenueCat/purchases-hybrid-common#1565
- react-native-purchases:
RevenueCat/react-native-purchases#1679
@rickvdl rickvdl merged commit 909a510 into main Mar 18, 2026
8 checks passed
@rickvdl rickvdl deleted the rickvdl/custom-paywall-impression-offering-id-override branch March 18, 2026 08:58
rickvdl added a commit to RevenueCat/purchases-capacitor that referenced this pull request Mar 18, 2026
## Summary
- Expose `trackCustomPaywallImpression` as a public API in Capacitor
- Support optional `paywallId` and `offeringId` parameters via
`TrackCustomPaywallImpressionOptions`
- If `offeringId` is not provided, the SDK uses the current offering
identifier from the cache
- Add prompt-based UI in purchase tester for testing with custom paywall
and offering IDs

## Changes
- **TypeScript:** `TrackCustomPaywallImpressionOptions` with `paywallId`
and `offeringId` in `definitions.ts`
- **iOS bridge:** `trackCustomPaywallImpression` in
`PurchasesPlugin.swift`
- **Android bridge:** `trackCustomPaywallImpression` in
`PurchasesPlugin.kt`
- **Web:** Mock implementation in `web.ts`
- **Purchase tester:** Prompt-based UI for entering paywall ID and
offering ID

### Related PRs
- purchases-hybrid-common:
RevenueCat/purchases-hybrid-common#1565
- react-native-purchases:
RevenueCat/react-native-purchases#1679
- purchases-unity:
RevenueCat/purchases-unity#869
rickvdl added a commit to RevenueCat/purchases-flutter that referenced this pull request Mar 18, 2026
## Summary
- Expose `trackCustomPaywallImpression` as a public API in Flutter
- Support optional `paywallId` and `offeringId` parameters via
`CustomPaywallImpressionParams`
- If `offeringId` is not provided, the SDK uses the current offering
identifier from the cache
- Pass full arguments dictionary to PHC on both iOS and Android instead
of unpacking individual fields
- Add purchase tester screen with text fields for paywall ID and
offering ID

## Changes
- **Dart:** `CustomPaywallImpressionParams` with `paywallId` and
`offeringId`
- **iOS bridge:** Pass arguments dictionary directly to
`[RCCommonFunctionality trackCustomPaywallImpression:]`
- **Android bridge:** Pass arguments map directly to
`CommonKt.trackCustomPaywallImpression()`
- **Tests:** Unit tests for all parameter combinations
- **API tester:** Compile-time verification of all API shapes
- **Purchase tester:** Screen with text fields for paywall ID and
offering ID

### Related PRs
- purchases-hybrid-common:
RevenueCat/purchases-hybrid-common#1565
- react-native-purchases:
RevenueCat/react-native-purchases#1679
- purchases-unity:
RevenueCat/purchases-unity#869
- purchases-capacitor:
RevenueCat/purchases-capacitor#725
This was referenced Mar 18, 2026
facumenzella pushed a commit that referenced this pull request Mar 18, 2026
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* Add offeringId override to trackCustomPaywallImpression (#1679) via
Rick (@rickvdl)
### 📦 Dependency Updates
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 17.52.0 (#1680)
via RevenueCat Git Bot (@RCGitBot)

## RevenueCatUI SDK
### ✨ New Features
* Add number and boolean support for CustomVariable (#1675) via Facundo
Menzella (@facumenzella)

---------

Co-authored-by: RevenueCat CI <dev+ci@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:feat A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants