Require PR approval before release tagging#811
Merged
Conversation
6533752 to
7e8343d
Compare
This version includes a `validate_pr_approved` check in `tag-current-branch` that verifies the release PR has been approved before the tag is created. Made-with: Cursor
7e8343d to
73d7353
Compare
tonidero
approved these changes
Mar 23, 2026
tonidero
pushed a commit
that referenced
this pull request
Mar 24, 2026
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Refactor wallet button renderer (#810) via Marek Dabek (@marek-dabek) ### 🐞 Bugfixes * Add font-family to simulated store modal (#809) via Perttu (@plahteenlahti) * Fix price-per-period rounding to floor instead of round-half-up (#807) via Dan Pannasch (@dpannasch) ### 🔄 Other Changes * Require PR approval before release tagging (#811) via Antonio Pallares (@ajpallares) * PW-1121 | Add paywall events (impression, close, cancel) (#806) via Drago Crnjac (@popcorn)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The release workflow currently allows tagging a release branch without verifying that the PR has been reviewed and approved. This adds a safeguard to ensure the release PR is properly approved before the tag is created.
Description
Bumps
revenuecat/sdks-common-configorb to@3.16.0, which includes avalidate_pr_approvedstep in thetag-current-branchjob. This verifies the release PR has been approved by an org member with write permissions before the git tag is created.Depends on: RevenueCat/sdks-circleci-orb#41