Don't allow empty string for appUserID during initialization#995
Merged
Conversation
|
This pull request has been linked to Shortcut Story #10159: Don't allow empty string for AppUserId during Purchases initialization. |
appUserID during initialization
NachoSoto
commented
Nov 27, 2021
NachoSoto
commented
Nov 27, 2021
Contributor
Author
There was a problem hiding this comment.
I made the conscious choice to not trim whitespaces for a not-empty user ID.
For example, " nacho with spaces " still remains the same, but " " is considered empty.
Not sure why somebody would want leading or trailing whitespaces, but I figured we wouldn't want to change that behavior.
aboedo
reviewed
Nov 29, 2021
aboedo
approved these changes
Nov 29, 2021
aboedo
left a comment
Member
There was a problem hiding this comment.
looks great! Left a couple of minor comments but otherwise good to go
appUserID during initializationappUserID during initialization
Contributor
Author
|
Thanks for the review! Still waiting to hear back from support before merging #974, which this PR depends on. |
NachoSoto
added a commit
to RevenueCat/purchases-android
that referenced
this pull request
Nov 29, 2021
…o anonymous Fixes [sc-10159]. See also RevenueCat/purchases-ios#995 for iOS equivalent.
135c711 to
af1f3a0
Compare
f3e3cd8 to
d3e288e
Compare
NachoSoto
added a commit
to RevenueCat/purchases-android
that referenced
this pull request
Nov 29, 2021
…o anonymous (#384) Fixes [sc-10159]. See also RevenueCat/purchases-ios#995 for iOS equivalent.
d3e288e to
8f41966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes [sc-10159].
Based on top of #974 because it contains a significant simplification of
IdentityManagerthat makes this a lot easier.Note that
Purchases.logInwill still fail with an error when trying to use an empty string. This PR does not change that behavior.