feat(remote-config): add manifest disk persistence by rickvdl · Pull Request #7076 · RevenueCat/purchases-ios

rickvdl · 2026-06-24T10:05:24Z

Part of a stack of PRs, builds on #7046 and should be aligned with the Android equivalent in RevenueCat/purchases-android#3612.

Description

Introduces the RemoteConfigDiskCache for storing the latest manifest, topic blob refs and other data through the PersistedRemoteConfiguration type.

Reading and writing from/to this persistence layer will be added in a follow up PR.

Note

Low Risk
New isolated persistence layer with no production call sites yet; failures degrade to nil reads and error logs.

Overview
Adds on-disk persistence for remote config sync metadata via RemoteConfigDiskCache and PersistedRemoteConfiguration (manifest, domain, active topics, prefetch blobs, topic blob refs, lastRefreshAt), backed by SynchronizedLargeItemCache under remote_config/remote_config.json (Application Support on most platforms, cache on tvOS).

RemoteConfigStrings logs read/write failures; RemoteConfiguration.defaultDomain is shared with RemoteConfigRequest instead of a local "app" constant. PersistedRemoteConfiguration decoding tolerates missing fields and ignores legacy on-disk topics bodies. A small file overwrite test was added in LargeItemCacheTypeTests.

Wiring this cache into fetch/refresh is not in this PR (follow-up).

^{Reviewed by Cursor Bugbot for commit e07ec6d. Bugbot is set up for automated code reviews on this repo. Configure here.}

rickvdl · 2026-06-24T11:01:10Z

Stack:

emerge-tools · 2026-06-24T11:11:06Z

4 builds increased size

Name	Version	Download	Change	Install	Change	Approval
RevenueCat com.revenuecat.PaywallsTester	1.0 (1)	18.9 MB	⬆️ 15.7 kB (0.08%)	68.4 MB	⬆️ 60.9 kB (0.09%)	N/A
BinarySizeTest com.revenuecat.binary-size-test.local-source	1.0 (1)	4.4 MB	⬇️ 159 B	13.1 MB	⬆️ 1.9 kB (0.01%)	N/A
BinarySizeTest com.revenuecat.binary-size-test.cocoapods	1.0 (1)	6.6 MB	⬆️ 1.1 kB (0.02%)	28.9 MB	⬆️ 6.1 kB (0.02%)	N/A
BinarySizeTest com.revenuecat.binary-size-test.spm	1.0 (1)	4.5 MB	⬇️ 1.2 kB (-0.03%)	11.5 MB	⬆️ 1.8 kB (0.02%)	N/A

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 60.9 kB (0.09%)
Total download size change: ⬆️ 15.7 kB (0.08%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 18.7 kB
DYLD.Exports	⬆️ 1.7 kB
Code Signature	⬆️ 1.2 kB
Other	⬆️ 39.2 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.9 kB (0.01%)
Total download size change: ⬇️ 159 B

Largest size changes

Item	Install Size Change
Other	⬆️ 1.9 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 6.1 kB (0.02%)
Total download size change: ⬆️ 1.1 kB (0.02%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 3.1 kB
Other	⬆️ 2.9 kB

View Treemap

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm

⚖️ Compare build
📦 Install build
⏱️ Analyze build performance

Total install size change: ⬆️ 1.8 kB (0.02%)
Total download size change: ⬇️ 1.2 kB (-0.03%)

Largest size changes

Item	Install Size Change
Other	⬆️ 1.8 kB

View Treemap

🛸 Powered by Emerge Tools

rickvdl · 2026-06-24T11:34:18Z

@RCGitBot please test

rickvdl · 2026-06-24T11:34:37Z

@tonidero I extracted the manifest persistence work into a separate PR to keep the PR size below the limits

rickvdl · 2026-06-25T05:18:00Z

@RCGitBot please test

rickvdl · 2026-06-25T12:28:32Z

@RCGitBot please test

rickvdl · 2026-06-25T13:35:04Z

@RCGitBot please test

tonidero

Not sure if we want to remove the RemoteConfigManifestToken in this PR or a follow-up (or leave it). But in any case, just some non-blocking comments from me

tonidero · 2026-06-25T13:43:17Z

+    let manifest: RemoteConfigManifestToken
+    let activeTopics: [String]
+    let prefetchBlobs: [String]
+    let topicBlobRefs: [String: [String]]


[not related to this PR]
I do think we will need to revisit the cleanup of topics... This is meant to help knowing which blobs are referenced to cleanup those that aren't, but if a topic item disappears, I believe this won't catch that, and the blob would keep living forever (or until the topic is deleted). Only if there is a modification, this would help delete older blobs I think... In any case, not related to this PR.

Good point, I have noted that for the follow up PR. Thanks!

rickvdl · 2026-06-25T14:49:23Z

@RCGitBot please test

…tence

…istence

rickvdl · 2026-06-25T15:17:04Z

@RCGitBot please test

emerge-tools · 2026-06-25T15:17:48Z

📸 Snapshot Test

1 modified, 858 unchanged

Name	Modified	Unchanged	Approval
Paywall Rendering Validation (ios) com.revenuecat.paywall-rendering-validation.ios	1	129	✅ Approved
PaywallsTester V1 swift-snapshot-testing com.revenuecat.PaywallsTester.v1-snapshots	0	65	N/A
Paywall Rendering Validation (mac-catalyst-optimized-for-mac) com.revenuecat.paywall-rendering-validation.mac-catalyst-optimized-for-mac	0	130	N/A
RevenueCat com.revenuecat.PaywallsTester	0	274	N/A
Paywall Rendering Validation (mac-native) com.revenuecat.paywall-rendering-validation.mac-native	0	130	N/A
Paywall Rendering Validation (mac-catalyst-scaled-to-match-ipad) com.revenuecat.paywall-rendering-validation.mac-catalyst-scaled-to-match-ipad	0	130	N/A

🛸 Powered by Emerge Tools

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 97e93b7. Configure here.}

rickvdl · 2026-06-25T15:32:04Z

@RCGitBot please test

rickvdl added pr:other feat:remote-config labels Jun 24, 2026

This was referenced Jun 24, 2026

feat(remote-config): update request and response models according to spec #7022

Merged

feat(remote-config): add RemoteConfigManager #7067

Open

feat(remote-config): store inlined blobs to disk #7073

Open

This was referenced Jun 24, 2026

refactor(remote-config): make rc container validation domain-specific #7074

Open

feat(remote-config): verify RC container signatures #7046

Merged

rickvdl changed the title ~~feat(remote-config): add manifest disk cache~~ feat(remote-config): add manifest disk persistence Jun 24, 2026

rickvdl force-pushed the rickvdl/remote-config-rc-container-signing branch from 41ad3fe to fbcb45e Compare June 24, 2026 11:07

rickvdl force-pushed the rickvdl/remote-config-manifest-cache branch from 7df5554 to af1f08a Compare June 24, 2026 11:08

rickvdl marked this pull request as ready for review June 24, 2026 11:34

rickvdl requested a review from a team as a code owner June 24, 2026 11:34

cursor Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread Sources/Networking/RemoteConfigDiskCache.swift Outdated

rickvdl mentioned this pull request Jun 25, 2026

feat(remote-config): switch config request to v1 and send app user id #7080

Open

rickvdl force-pushed the rickvdl/remote-config-rc-container-signing branch from fbcb45e to 0e2b685 Compare June 25, 2026 06:21

rickvdl force-pushed the rickvdl/remote-config-manifest-cache branch 2 times, most recently from d8380ab to 4af87a6 Compare June 25, 2026 07:09

ajpallares reviewed Jun 25, 2026

View reviewed changes

Comment thread Sources/Networking/Responses/RemoteConfiguration.swift Outdated

ajpallares reviewed Jun 25, 2026

View reviewed changes

Comment thread Sources/Networking/RemoteConfigDiskCache.swift

Comment thread Sources/Networking/Responses/RemoteConfiguration.swift Outdated

Comment thread Sources/Networking/RemoteConfigDiskCache.swift

ajpallares reviewed Jun 25, 2026

View reviewed changes

Comment thread Sources/Networking/RemoteConfigDiskCache.swift Outdated

cursor Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread Tests/UnitTests/Networking/RemoteConfig/RemoteConfigDiskCacheTests.swift

rickvdl force-pushed the rickvdl/remote-config-manifest-cache branch from d9de11a to 8950dab Compare June 25, 2026 13:36

rickvdl mentioned this pull request Jun 25, 2026

Make LargeItemCache writes atomic #7081

Merged

rickvdl requested a review from ajpallares June 25, 2026 13:43

tonidero approved these changes Jun 25, 2026

View reviewed changes

rickvdl force-pushed the rickvdl/remote-config-rc-container-signing branch from d4be3c0 to 7f539c0 Compare June 25, 2026 14:12

rickvdl force-pushed the rickvdl/remote-config-manifest-cache branch from 0e55d5e to caff100 Compare June 25, 2026 14:18

rickvdl force-pushed the rickvdl/remote-config-rc-container-signing branch from 7f539c0 to 05c7ac5 Compare June 25, 2026 14:30

rickvdl force-pushed the rickvdl/remote-config-manifest-cache branch from caff100 to 25ac068 Compare June 25, 2026 14:46

Base automatically changed from rickvdl/remote-config-rc-container-signing to main June 25, 2026 15:04

rickvdl added 12 commits June 25, 2026 17:16

feat(remote-config): add manifest disk cache

592fc3f

fix(remote-config): log missing manifest cache directory

24969bb

fix(remote-config): use snake case manifest cache path

4136a2c

fix(remote-config): address manifest cache review feedback

9fd9f0f

refactor(remote-config): reuse synchronized cache for manifest persis…

fd2994e

…tence

refactor(remote-config): expose synchronized cache URL

60fa9d1

refactor(remote-config): simplify cache write logging

a91b66f

test(remote-config): clean resolved cache directory

c11b5b3

refactor(remote-config): split atomic cache writes from manifest pers…

7f09c58

…istence

test(remote-config): cover shared cache overwrites

8dc5a64

refactor(remote-config): store manifest as string

5c065d3

refactor(remote-config): keep synchronized cache URL private

97e93b7

rickvdl force-pushed the rickvdl/remote-config-manifest-cache branch from 25ac068 to 97e93b7 Compare June 25, 2026 15:16

cursor Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread Sources/Caching/LargeItemCacheType.swift Outdated

fix(remote-config): preserve atomic cache writes

e07ec6d

rickvdl merged commit 52f0ee8 into main Jun 25, 2026
44 checks passed

rickvdl deleted the rickvdl/remote-config-manifest-cache branch June 25, 2026 15:50

Uh oh!

Conversation

rickvdl commented Jun 24, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

rickvdl commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emerge-tools Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4 builds increased size

RevenueCat 1.0 (1)com.revenuecat.PaywallsTester

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.local-source

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.cocoapods

BinarySizeTest 1.0 (1)com.revenuecat.binary-size-test.spm

Uh oh!

rickvdl commented Jun 24, 2026

Uh oh!

rickvdl commented Jun 24, 2026

Uh oh!

Uh oh!

rickvdl commented Jun 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rickvdl commented Jun 25, 2026

Uh oh!

rickvdl commented Jun 25, 2026

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tonidero Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

rickvdl Jun 25, 2026

Choose a reason for hiding this comment

Uh oh!

rickvdl commented Jun 25, 2026

Uh oh!

rickvdl commented Jun 25, 2026

Uh oh!

emerge-tools Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📸 Snapshot Test

1 modified, 858 unchanged

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rickvdl commented Jun 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rickvdl commented Jun 24, 2026 •

edited by cursor Bot

Loading

rickvdl commented Jun 24, 2026 •

edited

Loading

emerge-tools Bot commented Jun 24, 2026 •

edited

Loading

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.local-source

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.cocoapods

BinarySizeTest 1.0 (1)
com.revenuecat.binary-size-test.spm

emerge-tools Bot commented Jun 25, 2026 •

edited

Loading