Remove legacy BackendIntegrationTests targets from RevenueCat.xcodeproj#7006
Merged
facumenzella merged 2 commits intoJun 15, 2026
Merged
Conversation
These targets (BackendIntegrationTests, BackendCustomEntitlementsIntegrationTests, BackendIntegrationTestsHostApp) now run via RevenueCat-Tuist.xcworkspace after #6774, so they're dead weight in the legacy project. Also removes the dead BackendIntegrationTests scheme and the now-orphaned file/group references. Test source files stay on disk (owned by the Tuist RevenueCatTests project). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ajpallares
approved these changes
Jun 15, 2026
ajpallares
left a comment
Member
There was a problem hiding this comment.
Thank you for the cleanup! 🚀
Member
Author
|
Looks like the failing ones are flaky tests and an issue addressed in #7003 |
2 tasks
facumenzella
added a commit
that referenced
this pull request
Jun 19, 2026
Move test_ios/tvos/watchos/macos off the legacy RevenueCat.xcworkspace onto RevenueCat-Tuist.xcworkspace, mirroring how #7006 migrated BackendIntegrationTests. - Repoint the CI test plans (CI-RevenueCat, CI-RevenueCat-Snapshots, CI-Snapshots, CI-AllTests) to the Tuist RevenueCatTests/RulesEngineInternal projects. CI-AllTests code coverage set to false (it targeted the legacy RevenueCat framework and is consumed nowhere in CI). - Add a shared RevenueCatTests scheme wired to the four plans. - Align UnitTestsHostApp deployment targets with the legacy project (macOS 11, tvOS 14, watchOS 7) so the scene-lifecycle host app builds. - Point the four lanes at RevenueCat-Tuist.xcworkspace + RevenueCatTests; convert test_macos to scan. - Add tuist-generate-workspace to the six CI jobs running these lanes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After #6774 moved the backend integration tests onto
RevenueCat-Tuist.xcworkspace, the matching targets in the legacyRevenueCat.xcodeprojare dead weight. This removes them, another step toward fully retiringRevenueCat.xcodeproj+RevenueCat.xcworkspacein favor of Tuist.Description
Removes three now-unused targets from the legacy project:
BackendIntegrationTests,BackendCustomEntitlementsIntegrationTests, andBackendIntegrationTestsHostApp(the last two share the host app, so they go together). Also drops the deadBackendIntegrationTestsscheme and prunes the orphaned file/group references it left behind.The test sources stay on disk, they're owned by the Tuist
RevenueCatTestsproject now. CI already runs all backend integration test plans through the Tuist workspace, so nothing in CI references these targets anymore.This is a partial cleanup, not full workspace deletion:
RevenueCat.xcworkspaceis still needed by theRevenueCat,RevenueCatUIDev, andPurchaseTesterschemes.AI session context
AI Context
Metadata
facu/remove-legacy-backend-integration-targetsGoal
Remove the backend-integration test targets from the legacy
RevenueCat.xcodeproj/RevenueCat.xcworkspacenow that #6774 routed those tests throughRevenueCat-Tuist.xcworkspace, and confirm nothing in CI still needs them.Initial Prompt
"We've merged #6774. Can we remove these test targets from RevenueCat.xcworkspace now?" Followed by: the end state is everything accessible via Tuist (
RevenueCat-Tuist.xcworkspace); make sure CI has nothing that still needs the legacy targets. Cleanup scope chosen: full prune of orphaned references.Agent Contribution
backend_integration_testsFastlane lane + CIrun-backend-testsjob to the Tuist workspace, and that the 8 xctestplans repoint atRevenueCatTests.xcodeproj..circleci/,.github/,fastlane/,scripts/,Tests/.xcodeprojRuby gem (1.27.0) rather than hand-editing the 855KB pbxproj; cleaned gem leftovers the tool doesn't GC (orphanedTargetAttributes, container proxies, build configs, Info.plist/group refs).Human Decisions
Key Implementation Decisions
BackendCustomEntitlementsIntegrationTestsalso depends onBackendIntegrationTestsHostAppand is likewise Tuist-routed; removing the host app forces removing it.xcodeprojgem, not manual pbxproj edits.Files / Symbols Touched
RevenueCat.xcodeproj/project.pbxproj+lines are pure relocations from gem reserialization (verified zero genuinely-new content); all net changes are deletions.RevenueCat.xcodeproj/xcshareddata/xcschemes/BackendIntegrationTests.xcschemeDependencies / Config / Migrations
Validation
xcodebuild -list -workspace RevenueCat.xcworkspace: parses cleanly,BackendIntegrationTestsscheme absent, all surviving schemes resolve.plutil -lint project.pbxproj: OK.grep BackendIntegration project.pbxproj: 0.comm): 0 genuinely-new lines, all additions are relocations.Validation Gaps
tuist generate+ build; relied onProjects/RevenueCatTests/Project.swiftdefining all three targets + Use Tuist workspace for BackendIntegrationTests in CI #6774's CI wiring as proof of Tuist ownership.Review Focus
Risks / Reviewer Notes
Non-goals / Out of Scope
RevenueCat.xcodeproj/RevenueCat.xcworkspace(still used by other schemes).Omitted Context
Note
Low Risk
Xcode project/scheme-only cleanup with no source, dependency, or CI lane changes; main risk is a local workflow that still opened the removed legacy scheme.
Overview
Strips duplicate backend integration test wiring from the legacy
RevenueCat.xcodeprojnow that those suites run from the TuistRevenueCatTestsproject (#6774).Removed from the legacy project:
BackendIntegrationTests,BackendCustomEntitlementsIntegrationTests, and sharedBackendIntegrationTestsHostApp, plus theBackendIntegrationTestsshared scheme and orphanedpbxprojreferences (groups, build configs, container proxies). Test sources on disk are unchanged—they remain referenced byProjects/RevenueCatTests/Project.swift.RevenueCat.xcworkspace/ the rest of the legacy project stay for other schemes (RevenueCat,PurchaseTester, etc.).Reviewed by Cursor Bugbot for commit 195ef0f. Bugbot is set up for automated code reviews on this repo. Configure here.