fix(tuist): add missing test target deps#6894
Merged
Merged
Conversation
ajpallares
reviewed
Jun 3, 2026
| ], | ||
| dependencies: [ | ||
| .revenueCat, | ||
| .revenueCatUI, |
Member
There was a problem hiding this comment.
This shouldn't be needed I think? Unit tests should only depend on RevenueCat and not on the UI module 🤔
Contributor
Author
There was a problem hiding this comment.
The build is failing on this existing test:
e1cd1d8 to
5be234b
Compare
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
5be234b to
11b49ae
Compare
Contributor
Author
|
@RCGitBot please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
tuist generate-ed build was failing becauseButtonComponentViewModelInteractionTestswas in the wrong group (UnitTests instead ofRevenueCatUITest) -> movednimblewas missing from dependenciesNote
Low Risk
Test and project-configuration only; no production SDK or runtime behavior changes.
Overview
Fixes Tuist-generated builds that were failing on test target setup.
RevenueCatAdMobTestsnow declares Nimble as a dependency inProjects/RevenueCatTests/Project.swift, matching tests that import Nimble.The regenerated
project.pbxprojmovesButtonComponentViewModelInteractionTests.swiftfrom the UnitTests Components group into RevenueCatUITests → PaywallsV2, alongside other Paywalls V2 UI tests (the file uses@testable import RevenueCatUIand Nimble). Most other diff hunks are file-reference reordering from Tuist, not behavioral changes.Reviewed by Cursor Bugbot for commit 11b49ae. Bugbot is set up for automated code reviews on this repo. Configure here.