Add JSON Logic `min` and `max` operators by ajpallares · Pull Request #6825 · RevenueCat/purchases-ios

ajpallares · 2026-05-20T17:52:38Z

Checklist

Tests (as JSON predicate fixtures)

Motivation

Adds min / max so audience predicates can compare values against numeric extrema. Resolves SDK-4344. Stacked on #6817.

Description

Variadic flat-list shape per json-logic-js; operands coerce via JS Number() (like - / / / %, not parseFloat as in + / *). No iteration or projection.
Empty input returns ±∞ (mirrors Math.min() / Math.max()); non-numeric operands coerce to NaN and poison the result, so a malformed predicate fails closed against a numeric threshold.
Coverage is declarative JSON (min.json / max.json) run by the shared fixture runner; no Swift unit tests.

Note

Low Risk
Isolated rules-engine operator addition with extensive fixture tests; no auth, purchases, or data-path changes.

Overview
Adds JSON Logic min and max operators to the rules engine so audience predicates can compare values against numeric extrema (aligned with JS Math.min / Math.max).

Operands are a flat variadic list ({"min": [a, b, ...]}); each value coerces via Value.asNumber (JS Number()). Empty lists yield ±∞; invalid operands yield NaN, which fails closed when compared to thresholds. Wiring is in Operators.dispatch via new MinMaxOperators; coverage is declarative fixtures (min.json, max.json) with the shared fixture count raised to 307.

^{Reviewed by Cursor Bugbot for commit 7482442. Bugbot is set up for automated code reviews on this repo. Configure here.}

rickvdl

Nice addition!

…tures Convert the hand-written operator unit tests for operators available at the string+array level into declarative JSON predicate fixtures sharing khepri's conformance format, run by a shared runner that auto-discovers every file in PredicateFixtures/. `expected` is a khepri-compatible superset (Bool or { "error": ... }) plus optional `description` and `expectedWarnings`. Adds a test-only Value: Decodable conformance so predicates and variables decode straight into the engine's value model; production Value is unchanged. Tests that can't be expressed as predicate->Bool stay in Swift; ValueTests untouched. Test-only change. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 40901e5)

Load the in-repo fixtures once and feed the decoded cases straight into the parameterized test, instead of collecting IDs and re-reading every file to find the matching case per ID. PredicateConformanceFixtureCase gains Identifiable + Sendable (for the arguments) and a CustomTestStringConvertible extension so each case still displays by id. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Asserting an exact warning count coupled the fixtures to engine internals. Match warnings by substring only (count-agnostic); an empty `contains` now asserts that no warning is emitted, preserving the "does not warn" cases. The three count-only fixtures gain the "missing variable" substring they actually emit. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com>

Drop the khepri single-file plumbing (defaultFixtureURL, fixtureURL, the no-arg loadCases(), the env var, and the unused fixtureNotFound error). This PR only runs the in-repo PredicateFixtures/ directory; the khepri conformance loader lands with its test in the conformance PR. Co-authored-by: Cursor <cursoragent@cursor.com>

Implements the json-logic-js some/all iteration predicates. Operator coverage is expressed as JSON predicate fixtures (some.json / all.json) run by the shared fixture runner introduced downstack, replacing hand-written unit tests. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit d11529c)

Implements the json-logic-js min/max operators (variadic flat list, ±∞ for empty input, NaN propagation for non-numeric operands). Coverage is expressed as JSON predicate fixtures (min.json / max.json) run by the shared fixture runner, replacing hand-written unit tests. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit e73eabe)

Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # RevenueCat.xcodeproj/project.pbxproj

Expresses the "empty-string key resolves to the whole scope and is not missing" case as a `{"!!":{"missing":[""]}}` -> false fixture; the string coercion the other missing fixtures use can't distinguish [] from [""]. Bumps the pinned fixture count to 237. Keeps the corpus in sync with the purchases-android counterpart. Co-authored-by: Cursor <cursoragent@cursor.com>

Adds fixtures for the empty-segment dot-path splits, var default-vs-null-leaf behavior, and the non-numeric missing_some threshold (7 new cases), bumping the pinned count to 244. Also adds the var-null-path Swift test so the non-fixturizable cases match the purchases-android counterpart. Keeps the fixture corpus byte-identical across both repos. Co-authored-by: Cursor <cursoragent@cursor.com>

…-logic-iteration-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

…json-logic-min-max-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

Co-authored-by: Cursor <cursoragent@cursor.com>

…json-logic-min-max-operators

- Rename the object-array some/all fixtures to describe behavior instead of referencing the khepri oracle - Add fixtures for literal predicates and non-boolean truthy predicate results - Drop the unused opName parameter from parseIterationArgs and return an optional items list so a non-array source is distinguishable from an empty one - Bump pinned fixture count to 271 Co-authored-by: Cursor <cursoragent@cursor.com>

Place operator docs on each op instead of duplicating at the type level; drop "not vacuous truth" wording. Co-authored-by: Cursor <cursoragent@cursor.com>

…-logic-iteration-operators

Add var-fed cases (including the single-array-arg NaN gotcha), min fail-closed and empty-list fail-closed coverage. Collapse the two-pass NaN scan + extremum into a single reducing fold. Pinned fixture count 294 -> 301. Co-authored-by: Cursor <cursoragent@cursor.com>

…erators' into pallares/json-logic-min-max-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

…teration-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

Label each operator grouping in Operators.dispatch per PR review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>

Rename the all-match fixture and add cases where only the first or only the middle item matches, addressing PR review feedback that the existing some coverage was order dependent. Co-authored-by: Cursor <cursoragent@cursor.com>

khepri guards all with notEmpty, so it returns false for an empty array like json-logic-js; drop the inaccurate claim that khepri returns true. Co-authored-by: Cursor <cursoragent@cursor.com>

…teration-operators

…erators' into pallares/json-logic-min-max-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4d696d6. Configure here.}

Remove the duplicate WorkflowsCacheTests.swift PBXFileReference introduced during a merge, and add a dedicated "Min and max" grouping comment so the min/max cases are no longer lumped under arithmetic. Co-authored-by: Cursor <cursoragent@cursor.com>

ajpallares · 2026-06-08T13:44:23Z

Merging based on the prior approval + the approval from RevenueCat/purchases-android#3552 which is the same diff but in Android

ajpallares added the pr:other label May 20, 2026

ajpallares marked this pull request as ready for review May 20, 2026 18:35

ajpallares requested a review from a team as a code owner May 20, 2026 18:35

ajpallares requested a review from a team May 20, 2026 18:35

rickvdl approved these changes May 20, 2026

View reviewed changes

ajpallares mentioned this pull request May 22, 2026

Add JSON Logic iteration operators (none, map, filter, reduce) #6834

Merged

ajpallares changed the base branch from pallares/json-logic-string-array-operators to pallares/json-logic-iteration-operators May 27, 2026 08:47

ajpallares force-pushed the pallares/json-logic-iteration-operators branch from f6c4c80 to d11529c Compare June 2, 2026 12:43

ajpallares force-pushed the pallares/json-logic-min-max-operators branch from d2ca6d6 to e73eabe Compare June 2, 2026 12:43

ajpallares force-pushed the pallares/json-logic-iteration-operators branch from d11529c to f6c4c80 Compare June 2, 2026 12:48

ajpallares force-pushed the pallares/json-logic-min-max-operators branch from e73eabe to d2ca6d6 Compare June 2, 2026 12:48

ajpallares force-pushed the pallares/json-logic-iteration-operators branch from f6c4c80 to 874649b Compare June 2, 2026 14:12

ajpallares force-pushed the pallares/json-logic-min-max-operators branch from d2ca6d6 to 03295d9 Compare June 2, 2026 14:13

ajpallares and others added 7 commits June 2, 2026 17:07

Merge branch 'main' into pallares/rules-engine-json-fixtures

ddd6937

Assert on the shared static fixtures in the load test

716481a

Co-authored-by: Cursor <cursoragent@cursor.com>

Trim ExpectedWarnings.contains doc comment

0803c94

Co-authored-by: Cursor <cursoragent@cursor.com>

ajpallares force-pushed the pallares/json-logic-iteration-operators branch from 874649b to db50103 Compare June 3, 2026 12:59

ajpallares force-pushed the pallares/json-logic-min-max-operators branch from 03295d9 to 8a445e2 Compare June 3, 2026 12:59

ajpallares and others added 3 commits June 3, 2026 15:07

Drop unreachable parse error branch from conformance runner

77d8e6c

Co-authored-by: Cursor <cursoragent@cursor.com>

Merge #6885 (drop parse branch) into #6817

b1f8aa5

Merge #6817 (drop parse branch) into #6825

c0281b7

ajpallares added a commit that referenced this pull request Jun 3, 2026

Merge #6825 (drop parse branch) into #6834

f91c088

ajpallares and others added 2 commits June 5, 2026 11:23

Merge branch 'main' into pallares/rules-engine-json-fixtures

7301998

Rename fixture dir helper and pin fixture count

4752b3d

Co-authored-by: Cursor <cursoragent@cursor.com>

ajpallares added 2 commits June 5, 2026 13:51

Merge #6885 (main) into #6817

ad87b94

Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # RevenueCat.xcodeproj/project.pbxproj

Merge #6817 (main) into #6825

976f241

Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # RevenueCat.xcodeproj/project.pbxproj

ajpallares added a commit that referenced this pull request Jun 5, 2026

Merge #6825 (main) into #6834

045d1d0

ajpallares and others added 12 commits June 5, 2026 17:37

Merge branch 'pallares/rules-engine-json-fixtures' into pallares/json…

31df7e6

…-logic-iteration-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

Merge branch 'pallares/json-logic-iteration-operators' into pallares/…

b5a6521

…json-logic-min-max-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

Remove accidentally committed .swiftpm workspace file

fe438e0

Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'pallares/json-logic-iteration-operators' into pallares/…

28393ad

…json-logic-min-max-operators

Tidy some/all doc comments

7bf0110

Place operator docs on each op instead of duplicating at the type level; drop "not vacuous truth" wording. Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'main' into pallares/rules-engine-json-fixtures

7ae5c2c

Merge branch 'pallares/rules-engine-json-fixtures' into pallares/json…

42cc4e8

…-logic-iteration-operators

Merge remote-tracking branch 'origin/pallares/json-logic-iteration-op…

178e825

…erators' into pallares/json-logic-min-max-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

ajpallares mentioned this pull request Jun 7, 2026

Add JSON Logic min and max operators RevenueCat/purchases-android#3552

Merged

2 tasks

ajpallares and others added 4 commits June 8, 2026 10:24

Merge remote-tracking branch 'origin/main' into pallares/json-logic-i…

1d0ab53

…teration-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

Add grouping comments to operator dispatcher

9f98885

Label each operator grouping in Operators.dispatch per PR review feedback. Co-authored-by: Cursor <cursoragent@cursor.com>

Add order-independence coverage for some operator

de532c2

Rename the all-match fixture and add cases where only the first or only the middle item matches, addressing PR review feedback that the existing some coverage was order dependent. Co-authored-by: Cursor <cursoragent@cursor.com>

Correct empty-array all fixture description

6b6ec22

khepri guards all with notEmpty, so it returns false for an empty array like json-logic-js; drop the inaccurate claim that khepri returns true. Co-authored-by: Cursor <cursoragent@cursor.com>

Base automatically changed from pallares/json-logic-iteration-operators to main June 8, 2026 09:05

ajpallares added 2 commits June 8, 2026 11:29

Merge remote-tracking branch 'origin/main' into pallares/json-logic-i…

807d5d4

…teration-operators

Merge remote-tracking branch 'origin/pallares/json-logic-iteration-op…

4d696d6

…erators' into pallares/json-logic-min-max-operators Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # Tests/RulesEngineInternalTests/PredicateFixtureTests.swift

cursor Bot reviewed Jun 8, 2026

View reviewed changes

Comment thread RevenueCat.xcodeproj/project.pbxproj Outdated

ajpallares mentioned this pull request Jun 8, 2026

Represent ±Infinity in test fixtures via test-only variables #6936

Merged

ajpallares merged commit 7fbf5e1 into main Jun 8, 2026
18 of 20 checks passed

ajpallares deleted the pallares/json-logic-min-max-operators branch June 8, 2026 13:44

RCGitBot mentioned this pull request Jun 8, 2026

[AUTOMATIC] Release/5.78.0 #6954

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add JSON Logic `min` and `max` operators#6825

Add JSON Logic `min` and `max` operators#6825
ajpallares merged 39 commits into
mainfrom
pallares/json-logic-min-max-operators

ajpallares commented May 20, 2026 •

edited by cursor Bot

Loading

Uh oh!

rickvdl left a comment

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

ajpallares commented Jun 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ajpallares commented May 20, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Motivation

Description

Uh oh!

rickvdl left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ajpallares commented Jun 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ajpallares commented May 20, 2026 •

edited by cursor Bot

Loading