Update baseline swiftinterface files for rickvdl/add-presented-offering-context-to-custom-paywall-events#6722
Merged
Conversation
40e2204 to
e2163fe
Compare
7de01b1
into
rickvdl/add-presented-offering-context-to-custom-paywall-events
4 of 5 checks passed
rickvdl
added a commit
that referenced
this pull request
May 28, 2026
…ing-context-to-custom-paywall-events` (#6722) * Add presented offering context to custom paywall events * Update API testers for offering-based custom paywall impression init * Add tests for placement and targeting in custom paywall events * Accept Offering for custom paywall impression and derive context * Decouple custom paywall wire request from PaywallEvent's nested context type * Look up offeringId in cached offerings to derive presented offering context * Update baseline swiftinterface files --------- Co-authored-by: Rick van der Linden <rick.vanderlinden@revenuecat.com>
rickvdl
added a commit
that referenced
this pull request
May 28, 2026
…ing-context-to-custom-paywall-events` (#6722) * Add presented offering context to custom paywall events * Update API testers for offering-based custom paywall impression init * Add tests for placement and targeting in custom paywall events * Accept Offering for custom paywall impression and derive context * Decouple custom paywall wire request from PaywallEvent's nested context type * Look up offeringId in cached offerings to derive presented offering context * Update baseline swiftinterface files --------- Co-authored-by: Rick van der Linden <rick.vanderlinden@revenuecat.com>
rickvdl
added a commit
that referenced
this pull request
Jun 1, 2026
…ing-context-to-custom-paywall-events` (#6722) * Add presented offering context to custom paywall events * Update API testers for offering-based custom paywall impression init * Add tests for placement and targeting in custom paywall events * Accept Offering for custom paywall impression and derive context * Decouple custom paywall wire request from PaywallEvent's nested context type * Look up offeringId in cached offerings to derive presented offering context * Update baseline swiftinterface files --------- Co-authored-by: Rick van der Linden <rick.vanderlinden@revenuecat.com>
rickvdl
added a commit
that referenced
this pull request
Jun 1, 2026
* Add presented offering context to custom paywall events * Update API testers for offering-based custom paywall impression init * Add tests for placement and targeting in custom paywall events * Accept Offering for custom paywall impression and derive context * Decouple custom paywall wire request from PaywallEvent's nested context type * Look up offeringId in cached offerings to derive presented offering context * Update baseline swiftinterface files for `rickvdl/add-presented-offering-context-to-custom-paywall-events` (#6722) * Add presented offering context to custom paywall events * Update API testers for offering-based custom paywall impression init * Add tests for placement and targeting in custom paywall events * Accept Offering for custom paywall impression and derive context * Decouple custom paywall wire request from PaywallEvent's nested context type * Look up offeringId in cached offerings to derive presented offering context * Update baseline swiftinterface files --------- Co-authored-by: Rick van der Linden <rick.vanderlinden@revenuecat.com> * Inline offering resolution as plain if-let in trackCustomPaywallImpression * Fix race between init and applicationWillEnterForeground in TransactionMetadataSyncHelper The syncIfNeeded call in Purchases.init races with the call from applicationWillEnterForeground: if the init task acquires isSyncing first (even with empty metadata), it blocks the foreground notification task from running. Removing the init call is safe because applicationWillEnterForeground fires reliably on startup and covers the sync need. * Revert "Fix race between init and applicationWillEnterForeground in TransactionMetadataSyncHelper" This reverts commit d977926. * Align CustomPaywallImpressionParams with Android: store context instead of Offering Matches the Android PR #3424 changes: - Replace `offering: Offering?` property with `@_spi(Internal) presentedOfferingContext` so the params object stores the derived context rather than the raw Offering - Add `@_spi(Internal)` designated init for hybrid SDK (PHC) passthrough of pre-resolved presentedOfferingContext without requiring an Offering object - Deprecate `init(paywallId:offeringId:)` in favour of `init(paywallId:offering:)` - Update `trackCustomPaywallImpression` resolution order to match Android: params.presentedOfferingContext → cached[offeringId] → cached.current - Update Swift and ObjC API testers accordingly * Fix lint: suppress line_length for @available deprecated message * Remove params.offering tests — property replaced by presentedOfferingContext * Update baseline swiftinterface files (#6864) * Include placement and targeting in custom paywall event map --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @rickvdl for rickvdl/add-presented-offering-context-to-custom-paywall-events
Note
Low Risk
Public API surface change limited to swiftinterface baselines; no runtime logic changes are included here, with risk mainly around source compatibility for consumers using these generated interfaces.
Overview
Updates the generated
*.swiftinterfacebaseline files across Apple platforms to extendCustomPaywallImpressionParamswith an optionaloffering: Offering?property.Adds a new initializer
init(paywallId:offering:), enabling custom paywall impression events to include the presentedOfferingcontext (in addition to the existingofferingId).Reviewed by Cursor Bugbot for commit 84119cc. Bugbot is set up for automated code reviews on this repo. Configure here.