Skip to content

Prepare next version: 5.71.0-SNAPSHOT#6720

Closed
RCGitBot wants to merge 2 commits into
mainfrom
bump/5.71.0-SNAPSHOT
Closed

Prepare next version: 5.71.0-SNAPSHOT#6720
RCGitBot wants to merge 2 commits into
mainfrom
bump/5.71.0-SNAPSHOT

Conversation

@RCGitBot

@RCGitBot RCGitBot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
No functional changes are present in the diff, so risk is minimal aside from potential release/versioning process confusion.

Overview
No code changes are included in the provided diff (+++ /dev/null only), so there’s nothing to review beyond an apparent placeholder/empty PR for the upcoming 5.71.0-SNAPSHOT version.

Reviewed by Cursor Bugbot for commit 889df13. Bugbot is set up for automated code reviews on this repo. Configure here.

@RCGitBot RCGitBot requested a review from a team as a code owner April 30, 2026 12:34
@RCGitBot RCGitBot requested a review from a team April 30, 2026 12:34
@ajpallares

Copy link
Copy Markdown
Member

Closing as it's a duplicate of #6719

@ajpallares ajpallares closed this Apr 30, 2026
@ajpallares ajpallares deleted the bump/5.71.0-SNAPSHOT branch April 30, 2026 12:36
ajpallares added a commit that referenced this pull request May 4, 2026
* Only run snapshot-bump workflow when `.version` changed

The `snapshot-bump` workflow used to run on every non-scheduled, non-`bump`
commit on `main`. Combined with `create_next_snapshot_version`'s only
de-duplication being "is the bump branch currently on the remote?", any
commit that landed on `main` between a release and the merge of its
follow-up bump PR could open a duplicate bump PR (e.g. #6720 was opened
20s after #6719 merged because `bump/<v>` had just been deleted).

Compute `version_file_changed` in the dynamic-config setup job by diffing
the triggering commit against its parent for `.version`, forward it via
`continuation/continue`'s `parameters` arg, and add it as a `when`
condition on the `snapshot-bump` workflow. Now the workflow only triggers
on commits that actually modified `.version` — i.e. the release commit
itself (where the lane runs the bump) and the bump merge commit (where
the lane no-ops because `.version` is now a SNAPSHOT). Unrelated commits
on `main` no longer race against an in-flight bump PR.

Made-with: Cursor

* Move continuation-parameter computation to a Node script

Mirrors the existing `.circleci/generate-requested-jobs-config.js` pattern
so future derived pipeline parameters can be added without growing the
inline shell in `.circleci/config.yml`.

Made-with: Cursor

* Drop now-redundant comment above continuation-parameters step

The Node script's name and its own comments already convey what this
step does.

Made-with: Cursor

* Drop redundant comments in default_config.yml

The parameter name is self-explanatory and the rationale already lives
in the generate-continuation-parameters.js script and commit history.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants