Generating new test snapshots for admob-ssv-poll-endpoint - ios-16#6644
Merged
polmiro merged 1 commit intoApr 21, 2026
Conversation
Generated by 🚫 Danger |
4cd2401 to
cdf18f3
Compare
cb8b499 to
2ac40be
Compare
2ac40be to
a21a7b3
Compare
polmiro
pushed a commit
that referenced
this pull request
Apr 21, 2026
polmiro
pushed a commit
that referenced
this pull request
Apr 21, 2026
polmiro
pushed a commit
that referenced
this pull request
Apr 21, 2026
polmiro
pushed a commit
that referenced
this pull request
Apr 22, 2026
polmiro
added a commit
that referenced
this pull request
Apr 22, 2026
* Add AdMob SSV poll endpoint and `pollAdMobSSVStatus` SPI * Trim verbose AdMob SSV transport comments. Align AdsAPI and cache-key inline documentation with existing repository comment density while preserving behavior. * Trim pollAdMobSSVStatus SPI documentation. Reduce prescriptive guidance in the internal API comment while keeping the key cancellation behavior note. * [skip ci] Generating new test snapshots (#6648) * [skip ci] Generating new test snapshots (#6647) * [skip ci] Generating new test snapshots (#6646) * [skip ci] Generating new test snapshots (#6645) * [skip ci] Generating new test snapshots (#6644) * [skip ci] Generating new test snapshots (#6642) * [skip ci] Generating new test snapshots (#6643) * Trigger CI for PR 6641 checks. Add a non-skip commit so required CircleCI statuses are reported on the current head. * Validate non-empty client transaction ID for AdMob SSV polling. Guard against empty client transaction IDs in the SPI and backend operation and add focused backend tests for the new error path. * [skip ci] Generating new test snapshots (#6652) * [skip ci] Generating new test snapshots (#6653) * Trigger CI for PR 6641 checks. Add a non-skip commit so required CircleCI statuses are reported on the current head. * Enable signature verification for AdMob SSV status path. Update HTTP request path tests to cover AdMob SSV signature and nonce behavior. * fix: address review — move AdMob SPI extension to dedicated file * fix: address review — fail fast when AdMob status mock is unstubbed * fix: address review — dedupe client transaction validation in backend operation * fix: address review — use enum for AdMob SSV poll status * fix: address review — allow extracted Purchases extensions to access backend * fix: address review — log unknown AdMob SSV statuses * fix: address review — add Purchases AdMob SSV mapping tests * fix: address review — map missing client transaction ID to configuration error * fix: address review — keep backend private by co-locating AdMob extension * fix: address review — remove unused raw-value conformance * fix: address review — assert warning log for unknown AdMob status * fix: address review — surface unknown AdMob SSV status to adapters * fix: address review — enable eTag support for AdMob SSV status path --------- Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @polmiro for admob-ssv-poll-endpoint
Note
Low Risk
Test-only snapshot additions; no runtime logic changes, with risk limited to potential snapshot brittleness if request headers change.
Overview
Updates the test suite by adding new iOS 16 snapshot fixtures for
BackendGetAdMobSSVStatusTests, capturing the expectedGET /v1/subscribers/{user}/ads/admob/ssv/{clientTransactionID}request (headers + URL).These snapshots cover the main request wiring plus concurrency/deduping scenarios and error/status cases, without changing production code.
Reviewed by Cursor Bugbot for commit a21a7b3. Bugbot is set up for automated code reviews on this repo. Configure here.