Select default package on BottomSheetView dismissal#5797
Merged
vegaro merged 6 commits intoNov 24, 2025
Merged
Conversation
📸 Snapshot Test2 modified, 478 unchanged
🛸 Powered by Emerge Tools |
JZDesign
approved these changes
Nov 14, 2025
Comment on lines
+71
to
+75
| .onChangeOf(sheetViewModel) { newValue in | ||
| if newValue == nil { | ||
| packageContext.package = defaultPackage | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think this deserves a comment explaining why if newValue == nil { is needed, or when is set back to nil ?
Member
Author
|
I have reverted the changes that tried to fix the package not being shown as selected in the |
BottomSheetView
BottomSheetViewBottomSheetView dismissal
JZDesign
approved these changes
Nov 20, 2025
…e-selection-after-closing-the-paywall-sheet
github-merge-queue Bot
pushed a commit
to RevenueCat/purchases-android
that referenced
this pull request
Nov 24, 2025
Equivalent of RevenueCat/purchases-ios#5797 Setting the default package back to default after dismissing Sheet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes default package not being selected back when closing Sheet