[Paywalls V2] Use V1 default paywall when footers are used with V2 paywalls#4667
Conversation
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| Code Signature | ⬆️ 7.4 kB |
| DYLD.String Table | ⬆️ 6.2 kB |
| DYLD.Exports | ⬆️ 1.2 kB |
| 📝 RevenueCatUI.PaywallsV2View.PaywallsV2View | ⬆️ 796 B |
| Other | ⬆️ 277.1 kB |
View Treemap
🛸 Powered by Emerge Tools
Comment trigger: Size diff threshold of 100.00kB exceeded
tonidero
left a comment
There was a problem hiding this comment.
Just a comment, but probably not enough time to act on it now. LGTM!
| // For fallback view or footer | ||
| let paywall: PaywallData = .createDefault(with: offering.availablePackages, | ||
| locale: self.locale) | ||
| let paywallView = LoadedOfferingPaywallView( |
There was a problem hiding this comment.
Hmm do we have to build the V1 paywallView before checking if it's actually needed? I guess we would need to validate the data before displaying it which might be quite a refactor... So I'm ok with this for now.
There was a problem hiding this comment.
@tonidero Just updated this if you want to have another look again! I moved the creation the view to inside PaywallsV2View by passing an enum with data (either data for the LoadedOfferingPaywallView for production or AnyView for tests)
There was a problem hiding this comment.
Ah nice! Yeah I think that's an improvement! I guess we do need to create the data for the default paywall before, but that's already a big improvement 👍
9e50ba3 to
289fc8d
Compare
… modes in a Components paywall (#2106) ### Description Until now, if trying to present a components paywall as a footer, it would display the paywall mostly full screen with some indeterminate behavior. After this, if the developer tries to present a paywall v2 as a footer/condensed footer, we will fallback to the original paywall fallback paywall, which uses template 2 right now. Android equivalent of RevenueCat/purchases-ios#4667 --------- Co-authored-by: JayShortway <29483617+JayShortway@users.noreply.github.com>
Motivation
We aren't planning to support footer paywalls in Paywalls V2
Description
Uses the Paywalls V1 footer with the default paywalls when a footer is requested with a Paywalls V2 paywall
Screen.Recording.2025-01-14.at.9.08.25.PM.mov