[Customer Center] Improving customer center buttons by codykerns · Pull Request #4165 · RevenueCat/purchases-ios

codykerns · 2024-08-09T17:34:58Z

Various improvements around buttons for Customer Center. Several changes for the case where the customer center is presented full screen but wasn't dismiss-able.

NoSubscriptionsView

Uses 'dismiss' localized string instead of 'cancel' for dismiss button

Button styles

Renames existing ManageSubscriptionButtonStyle to ProminentButtonStyle as it's used elsewhere
Adds a new reusable SubtleButtonStyle button style (standard, borderless style)
Slightly thickens button fonts to more closely match buttons in system modals
Slightly increases corner radius to more closely match buttons in system modals

New	Old

WrongPlatformView

Adds an explicit 'dismiss' button

New	Old

ManageSubscriptionsView

Fixes SDK-3537. Adds a toolbar 'dismiss' button to make sure it's dismiss-able when presented in full screen (or in scenarios where a swipe to dismiss isn't supported)

New	Old

jamesrb1 · 2024-08-12T03:45:32Z

Looks good, will give this a thoughtful review Monday morning.

jamesrb1

I think these are good changes, nice attention to detail. Pre-approving, but please see comments.

Side comment: I think this title area needs some UI design changes - it looks a bit cramped (localization may be hard), and having the dismiss button the same size and on the same as the screen's title makes the visual hierarchy not great.

jamesrb1

Looks good!

jamesrb1 · 2024-08-14T00:18:38Z

+    var body: some View {
+        if #available(iOS 16.0, *) {
+            NavigationStack {
+                content
+            }
+        } else {
+            NavigationView {
+                content
+            }
+        }
    }


This view will always be presented modally in some manner? If so this is fine, but if someone were to add this to an existing navigation stack, weird things could happen.

Additionally, I see we've used this pattern twice, if we use it a third time, should consider creating a component we can reuse for this.

The modal question is one we'll need to answer, good call 👍

Agreed on the reusable component - will pull this out into a new component in a separate PR.

@jamesrb1

**This is an automatic release.** ### New Features * Price rounding logic (#4132) via James Borthwick (@jamesrb1) ### Bugfixes * [Customer Center] Migrate to List style (#4190) via Cody Kerns (@codykerns) * [Paywalls] Improve locale consistency (#4158) via Josh Holtz (@joshdholtz) * Set Paywalls Tester deployment target to iOS 15 (#4196) via James Borthwick (@jamesrb1) * [Customer Center] Hide Contact Support button if URL can't be created (#4192) via Cesar de la Vega (@vegaro) * Fix the setting for SKIP_INSTALL in Xcode project (#4195) via Andy Boedo (@aboedo) * [Customer Center] Improving customer center buttons (#4165) via Cody Kerns (@codykerns) * Revert workaround for iOS 18 beta 5 SwiftUI crash (#4173) via Mark Villacampa (@MarkVillacampa) * [Paywalls] Make iOS version calculation lazy (#4163) via Mark Villacampa (@MarkVillacampa) * [Paywalls] Observe `PurchaseHandler` when owned externally (#4097) via James Borthwick (@jamesrb1) ### Other Changes * [Customer Center] Clean up colors in WrongPlatformView and NoSubscriptionsView (#4204) via Cesar de la Vega (@vegaro) * Fix failing `all-tests` and retry more flaky tests (#4188) via Josh Holtz (@joshdholtz) * Compatibility content unavailable improvements (#4197) via James Borthwick (@jamesrb1) * Create lane to enable customer center (#4191) via Cesar de la Vega (@vegaro) * XCFramework artifacts in CircleCI (#4189) via Andy Boedo (@aboedo) * [Customer Center] CustomerCenterViewModel checks whether the app is the latest version (#4169) via JayShortway (@JayShortway) * export RevenueCatUI xcframework (#4172) via Andy Boedo (@aboedo) * Corrects references from ManageSubscriptionsButtonStyle to ButtonsStyle. (#4186) via JayShortway (@JayShortway) * Speed up carthage installation tests (#4184) via Andy Boedo (@aboedo) * Customer center improvements (#4166) via James Borthwick (@jamesrb1) * replace `color(from colorInformation:)` global with extension (#4183) via Andy Boedo (@aboedo) * Fix tests in main (#4174) via Andy Boedo (@aboedo) * Enable customer center tests (#4171) via James Borthwick (@jamesrb1) * [Customer Center] Initial implementation (#3967) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Josh Holtz <me@joshholtz.com>

@jamesrb1

**This is an automatic release.** ### New Features * Price rounding logic (#4132) via James Borthwick (@jamesrb1) ### Bugfixes * [Customer Center] Migrate to List style (#4190) via Cody Kerns (@codykerns) * [Paywalls] Improve locale consistency (#4158) via Josh Holtz (@joshdholtz) * Set Paywalls Tester deployment target to iOS 15 (#4196) via James Borthwick (@jamesrb1) * [Customer Center] Hide Contact Support button if URL can't be created (#4192) via Cesar de la Vega (@vegaro) * Fix the setting for SKIP_INSTALL in Xcode project (#4195) via Andy Boedo (@aboedo) * [Customer Center] Improving customer center buttons (#4165) via Cody Kerns (@codykerns) * Revert workaround for iOS 18 beta 5 SwiftUI crash (#4173) via Mark Villacampa (@MarkVillacampa) * [Paywalls] Make iOS version calculation lazy (#4163) via Mark Villacampa (@MarkVillacampa) * [Paywalls] Observe `PurchaseHandler` when owned externally (#4097) via James Borthwick (@jamesrb1) ### Other Changes * [Customer Center] Clean up colors in WrongPlatformView and NoSubscriptionsView (#4204) via Cesar de la Vega (@vegaro) * Fix failing `all-tests` and retry more flaky tests (#4188) via Josh Holtz (@joshdholtz) * Compatibility content unavailable improvements (#4197) via James Borthwick (@jamesrb1) * Create lane to enable customer center (#4191) via Cesar de la Vega (@vegaro) * XCFramework artifacts in CircleCI (#4189) via Andy Boedo (@aboedo) * [Customer Center] CustomerCenterViewModel checks whether the app is the latest version (#4169) via JayShortway (@JayShortway) * export RevenueCatUI xcframework (#4172) via Andy Boedo (@aboedo) * Corrects references from ManageSubscriptionsButtonStyle to ButtonsStyle. (#4186) via JayShortway (@JayShortway) * Speed up carthage installation tests (#4184) via Andy Boedo (@aboedo) * Customer center improvements (#4166) via James Borthwick (@jamesrb1) * replace `color(from colorInformation:)` global with extension (#4183) via Andy Boedo (@aboedo) * Fix tests in main (#4174) via Andy Boedo (@aboedo) * Enable customer center tests (#4171) via James Borthwick (@jamesrb1) * [Customer Center] Initial implementation (#3967) via Cesar de la Vega (@vegaro) --------- Co-authored-by: Josh Holtz <me@joshholtz.com>

Improve button styles, add explicit dismiss buttons

841eb75

codykerns commented Aug 9, 2024

View reviewed changes

Comment thread RevenueCatUI/CustomerCenter/Views/NoSubscriptionsView.swift Outdated

codykerns commented Aug 9, 2024

View reviewed changes

Comment thread RevenueCatUI/CustomerCenter/ButtonStyles.swift Outdated

codykerns commented Aug 9, 2024

View reviewed changes

Comment thread RevenueCatUI/CustomerCenter/Views/ManageSubscriptionsView.swift

codykerns added pr:fix A bug fix feat:Customer Center labels Aug 9, 2024

lint for line count

a525f44

codykerns requested a review from a team August 9, 2024 18:28

codykerns marked this pull request as ready for review August 9, 2024 18:29

aboedo requested a review from jamesrb1 August 9, 2024 18:36

jamesrb1 approved these changes Aug 12, 2024

View reviewed changes

Comment thread RevenueCatUI/CustomerCenter/ButtonStyles.swift Outdated

Comment thread RevenueCatUI/CustomerCenter/Views/ManageSubscriptionsView.swift

Comment thread RevenueCatUI/CustomerCenter/Views/WrongPlatformView.swift Outdated

codykerns added 2 commits August 12, 2024 15:33

fix subtle button style padding

1658a0b

use custom dismiss button

838845e

codykerns requested a review from jamesrb1 August 13, 2024 15:49

jamesrb1 approved these changes Aug 14, 2024

View reviewed changes

codykerns added 2 commits August 14, 2024 13:40

Merge branch 'main' into cody/customer_center_button_polish

942e620

merge fix

2bb2f7e

vegaro approved these changes Aug 14, 2024

View reviewed changes

Comment thread RevenueCatUI/CustomerCenter/ButtonStyles.swift Outdated

Comment thread RevenueCatUI/CustomerCenter/ButtonStyles.swift

Comment thread RevenueCatUI/CustomerCenter/Views/ManageSubscriptionsView.swift

codykerns added 3 commits August 14, 2024 17:21

Style guide

95fa76d

lint

1081d7a

remove availability checks

d0fa75a

codykerns merged commit 76cbce1 into main Aug 14, 2024

codykerns deleted the cody/customer_center_button_polish branch August 14, 2024 22:02

JayShortway mentioned this pull request Aug 15, 2024

Corrects references from ManageSubscriptionsButtonStyle to ButtonsStyle. #4186

Merged

RCGitBot mentioned this pull request Aug 21, 2024

[AUTOMATIC] Release/5.3.0 #4205

Merged

vegaro mentioned this pull request Aug 23, 2024

[DO NOT MERGE] Release 5.3.0-customercenter.alpha.4 #4214

Closed

nyeu pushed a commit that referenced this pull request Oct 2, 2024

[Customer Center] Improving customer center buttons (#4165)

02c9251

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Customer Center] Improving customer center buttons#4165

[Customer Center] Improving customer center buttons#4165
codykerns merged 9 commits into
mainfrom
cody/customer_center_button_polish

codykerns commented Aug 9, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesrb1 commented Aug 12, 2024

Uh oh!

jamesrb1 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesrb1 left a comment

Uh oh!

jamesrb1 Aug 14, 2024

Uh oh!

codykerns Aug 14, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

codykerns commented Aug 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesrb1 commented Aug 12, 2024

Uh oh!

jamesrb1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamesrb1 left a comment

Choose a reason for hiding this comment

Uh oh!

jamesrb1 Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

codykerns Aug 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codykerns commented Aug 9, 2024 •

edited

Loading