Re-added the RevenueCatUI tests job on every commit#4113
Merged
Conversation
Member
Author
|
Oh, I guess re-doing the names sadly means that I'd have to also update the name in the required jobs list. |
aboedo
commented
Jul 24, 2024
Comment on lines
+1282
to
+1289
| - lint: | ||
| name: "swiftlint" | ||
| - run-test-ios-17: | ||
| name: "Unit tests" | ||
| - pod-lib-lint: | ||
| name: "Pod lib lint" | ||
| - spm-revenuecat-ui-ios-17: | ||
| name: "RevenueCatUI tests" |
Member
Author
There was a problem hiding this comment.
let me know if the name feels like it's not adding much and / or making it harder to map the jobs as they show up in github to the circleCI config. I just did this because the name spm-revenuecat-ui-ios-17 seemed so specific that it didn't seem like a vital check to have until I realized what it was
Contributor
There was a problem hiding this comment.
Hmm how about renaming the job to something like run-revenuecat-ui-ios-17 instead? I feel changing the name like this might make it harder to try to find what job is failing later.
Member
Author
|
@RCGitBot please test |
tonidero
approved these changes
Jul 29, 2024
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Just a comment but looks good!
| @@ -1269,7 +1269,7 @@ workflows: | |||
| jobs: | |||
| - spm-revenuecat-ui-ios-15 | |||
| - spm-revenuecat-ui-ios-16 | |||
Contributor
There was a problem hiding this comment.
I do wonder if we should also rename these, if they are doing the same thing but on different iOS versions...
jamesrb1
pushed a commit
that referenced
this pull request
Aug 7, 2024
I realized that we weren't running the suite of tests from RevenueCatUI in every commit. I missed this one because the name made it seem like it was a test specific to SPM, but it's just that it could only be run through SPM at the time. It can now be run from Xcode, but that's a separate story, so for now this just re-adds it and clarifies the naming a bit
MarkVillacampa
pushed a commit
that referenced
this pull request
Aug 7, 2024
**This is an automatic release.** ### Bugfixes * Fix Paywalls crash on iOS 18 beta (#4154) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.3 to 9.5.0 (#4143) via dependabot[bot] (@dependabot[bot]) * Bump nokogiri from 1.16.6 to 1.16.7 (#4129) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.221.1 to 2.222.0 (#4130) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Update deployment targets for tests (#4145) via Andy Boedo (@aboedo) * Deploy purchaserTester: clean up dry-run parameter (#4140) via Andy Boedo (@aboedo) * Clean up API Testers (#4141) via Andy Boedo (@aboedo) * More project structure cleanup (#4131) via Andy Boedo (@aboedo) * temporarily disables purchasetester deploy (#4133) via Andy Boedo (@aboedo) * Fix trigger all tests branch (#4135) via Andy Boedo (@aboedo) * Clean up XCWorkspace and testing apps (#4111) via Andy Boedo (@aboedo) * tests trigger: add target-branch parameter to trigger from the right branch (#4121) via Andy Boedo (@aboedo) * Re-added the RevenueCatUI tests job on every commit (#4113) via Andy Boedo (@aboedo)
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
I realized that we weren't running the suite of tests from RevenueCatUI in every commit. I missed this one because the name made it seem like it was a test specific to SPM, but it's just that it could only be run through SPM at the time. It can now be run from Xcode, but that's a separate story, so for now this just re-adds it and clarifies the naming a bit
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
**This is an automatic release.** ### Bugfixes * Fix Paywalls crash on iOS 18 beta (#4154) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.3 to 9.5.0 (#4143) via dependabot[bot] (@dependabot[bot]) * Bump nokogiri from 1.16.6 to 1.16.7 (#4129) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.221.1 to 2.222.0 (#4130) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Update deployment targets for tests (#4145) via Andy Boedo (@aboedo) * Deploy purchaserTester: clean up dry-run parameter (#4140) via Andy Boedo (@aboedo) * Clean up API Testers (#4141) via Andy Boedo (@aboedo) * More project structure cleanup (#4131) via Andy Boedo (@aboedo) * temporarily disables purchasetester deploy (#4133) via Andy Boedo (@aboedo) * Fix trigger all tests branch (#4135) via Andy Boedo (@aboedo) * Clean up XCWorkspace and testing apps (#4111) via Andy Boedo (@aboedo) * tests trigger: add target-branch parameter to trigger from the right branch (#4121) via Andy Boedo (@aboedo) * Re-added the RevenueCatUI tests job on every commit (#4113) via Andy Boedo (@aboedo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that we weren't running the suite of tests from RevenueCatUI in every commit.
I missed this one because the name made it seem like it was a test specific to SPM, but it's just that it could only be run through SPM at the time.
It can now be run from Xcode, but that's a separate story, so for now this just re-adds it and clarifies the naming a bit