[Customer Center] Build feedback survey from JSON#3959
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8957234 to
2f36ec7
Compare
2f36ec7 to
2d41724
Compare
f589baa to
000d6cd
Compare
000d6cd to
ad260d3
Compare
ad260d3 to
3dd2fb0
Compare
3dd2fb0 to
821016e
Compare
821016e to
06caec1
Compare
bd32cdd to
466858a
Compare
516fb3a to
6572cf1
Compare
6572cf1 to
7f655ec
Compare
afacfb8 to
b90528b
Compare
09cb7eb to
982d7a6
Compare
4bbc8de to
7268b6f
Compare
7268b6f to
8a1313f
Compare
af40602 to
62f405e
Compare
b58de4b to
3dcc74f
Compare
3dcc74f to
e0b4ea4
Compare
e0b4ea4 to
93ccbc5
Compare
8099f65 to
49d2a2d
Compare
e14b53c to
da7a147
Compare
tonidero
left a comment
There was a problem hiding this comment.
Just some questions but looking good!
| ForEach(options, id: \.id) { option in | ||
| Button(option.title) { | ||
| Task { | ||
| self.action() |
There was a problem hiding this comment.
Hmm so the way it is right now, every option will have the same action. However, we might have different actions right? Like some questions might provide a promotional offer and some won't. Do we need to change this and/or send back the id?
There was a problem hiding this comment.
You're correct. I built that in https://github.com/RevenueCat/purchases-ios/pull/3968/files#diff-b11601f94f84f34e8c7259de27e1760a2919c2ccb27d582eb7d4daa019d57f37 to keep this one simple, I should have make that more clear sorry!
| ForEach(options, id: \.id) { option in | ||
| Button(option.title) { | ||
| Task { | ||
| self.action() |
There was a problem hiding this comment.
A different question, if you press the button multiple times quickly, do we handle it gracefully? Mostly thinking about the Task we use here so not sure...
There was a problem hiding this comment.
Also handled in https://github.com/RevenueCat/purchases-ios/pull/3968/files#diff-b11601f94f84f34e8c7259de27e1760a2919c2ccb27d582eb7d4daa019d57f37R82 although it should be an AsyncButton actually, so I will update that in this PR
dynamic title
Based off #3933 https://github.com/RevenueCat/purchases-ios/assets/664544/11eae984-294a-4e14-8c40-7c2d50994c09 Can probably use some animations, but tuning that up will come up later It will open a feedback survey for an option if there's one
Based off #3933 https://github.com/RevenueCat/purchases-ios/assets/664544/11eae984-294a-4e14-8c40-7c2d50994c09 Can probably use some animations, but tuning that up will come up later It will open a feedback survey for an option if there's one
Based off #3933
Jun-14-2024.16-44-31.mp4
Can probably use some animations, but tuning that up will come up later
It will open a feedback survey for an option if there's one