Skip to content

[EXTERNAL] Fix Typos in ReceiptStrings.swift#3756

Merged
vegaro merged 1 commit into
RevenueCat:nickkohrn-fix-receipt-strings-typosfrom
nickkohrn:fix-receipt-strings-typos
Mar 13, 2024
Merged

[EXTERNAL] Fix Typos in ReceiptStrings.swift#3756
vegaro merged 1 commit into
RevenueCat:nickkohrn-fix-receipt-strings-typosfrom
nickkohrn:fix-receipt-strings-typos

Conversation

@nickkohrn

@nickkohrn nickkohrn commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

I wanted to fix simple typos in log messages to provide a slightly better developer experience.

Description

The changes include a fix for a typo in a string and a typo in an enumeration case declaration. Unit tests were not implemented for ReceiptStrings.swift, so I added unit tests to cover all ReceiptStrings members.

Notes

I looked for similar issues in the repositories for purchases-android and hybrids, but I did not find any.

@vegaro vegaro changed the title Fix Typos in ReceiptStrings.swift [EXTERNAL] Fix Typos in ReceiptStrings.swift Mar 13, 2024
@vegaro vegaro changed the base branch from main to nickkohrn-fix-receipt-strings-typos March 13, 2024 13:55
@vegaro vegaro merged commit afd2172 into RevenueCat:nickkohrn-fix-receipt-strings-typos Mar 13, 2024
@vegaro

vegaro commented Mar 13, 2024

Copy link
Copy Markdown
Member

Thanks for taking care of these!

vegaro added a commit that referenced this pull request Mar 13, 2024
…3760)

Merging #3756 into `main`

Co-authored-by: Nick Kohrn <nickkohrn@users.noreply.github.com>
@nickkohrn nickkohrn deleted the fix-receipt-strings-typos branch March 13, 2024 15:27
This was referenced Mar 13, 2024
vegaro pushed a commit that referenced this pull request Mar 13, 2024
**This is an automatic release.**

### RevenueCatUI
* Add `PaywallView.onRequestedDismissal` modifier and option to pass
`dismissRequestedHandler` to `PaywallViewController` (#3738) via Cesar
de la Vega (@vegaro)
### Bugfixes
* [EXTERNAL] Fix Typos in ReceiptStrings.swift (#3756) via @nickkohrn
(#3760) via Cesar de la Vega (@vegaro)
### Other Changes
* Pin xcbeautify version for xcode 14 tests (#3759) via Cesar de la Vega
(@vegaro)
* PaywallsTester: fix compilation (#3753) via Andy Boedo (@aboedo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants