New Package.presentedOfferingContext#3690
Merged
joshdholtz merged 15 commits intoFeb 14, 2024
Merged
Conversation
7984c51 to
7d1d7ce
Compare
NachoSoto
reviewed
Feb 14, 2024
presented_offering_identifier to an objectpresented_offering_identifier to PresentedOfferingContext
NachoSoto
reviewed
Feb 14, 2024
| super.init() | ||
| } | ||
|
|
||
| public override func isEqual(_ object: Any?) -> Bool { |
Contributor
There was a problem hiding this comment.
If you override this you also need to override hash or else bad things will happen when using these in maps and sets.
presented_offering_identifier to PresentedOfferingContextpresented_offering_identifier to PresentedOfferingContext
NachoSoto
reviewed
Feb 14, 2024
NachoSoto
left a comment
Contributor
There was a problem hiding this comment.
Just one last missing piece: api tests.
Also I'd change this to feat since it's adding a public API.
| /// | ||
| /// Stores information about how a ``Package`` was presented. | ||
| /// | ||
| @objc(RCPresentedOfferingContext) public final class PresentedOfferingContext: NSObject { |
Contributor
There was a problem hiding this comment.
Can you add this to the Swift/Obj-C API testers?
Member
Author
There was a problem hiding this comment.
OMG, how did I forget...
| Purchases.shared.cachePresentedOfferingIdentifier( | ||
| offering.identifier, | ||
| Purchases.shared.cachePresentedOfferingContext( | ||
| PresentedOfferingContext(offeringIdentifier: offering.identifier), |
Contributor
There was a problem hiding this comment.
Nit: I like to do this to avoid all the duplicated "offering context"
Suggested change
| PresentedOfferingContext(offeringIdentifier: offering.identifier), | |
| .init(offeringIdentifier: offering.identifier), |
Contributor
|
Maybe rename the PR to
So it's a clearer callout in the release notes, since it's more than a refactor. |
presented_offering_identifier to PresentedOfferingContextPackage.presentedOfferingContext
NachoSoto
approved these changes
Feb 14, 2024
| @implementation RCPresentOfferingContextAPI | ||
|
|
||
| + (void)checkAPI { | ||
| RCPresentedOfferingContext *poc; |
Comment on lines
+12
to
+16
| private var context: PresentedOfferingContext! | ||
| func checkPresentedOfferingContextAPI() { | ||
| let oID: String = context.offeringIdentifier | ||
|
|
||
| print(context!, oID) |
Contributor
There was a problem hiding this comment.
We've been simplifying these:
Suggested change
| private var context: PresentedOfferingContext! | |
| func checkPresentedOfferingContextAPI() { | |
| let oID: String = context.offeringIdentifier | |
| print(context!, oID) | |
| func checkPresentedOfferingContextAPI(context: PresentedOfferingContext! = nil) { | |
| let _: String = context.offeringIdentifier | |
| } |
Contributor
|
Do you mind rebasing? I just rebased |
477ade0 to
b884022
Compare
MarkVillacampa
pushed a commit
that referenced
this pull request
Feb 21, 2024
### Motivation Allow for storing of other presented offering context on a `Package` ### Description - Replaced `offeringIdentifier: String` on `Package` with new `presentedOfferingContext: PresentedOfferingContext` - Currently it only has a `offeringIdentifier: String` - Eventually this will add new optional properties for targeting and placements
joshdholtz
added a commit
that referenced
this pull request
Feb 23, 2024
### Motivation Allow for storing of other presented offering context on a `Package` ### Description - Replaced `offeringIdentifier: String` on `Package` with new `presentedOfferingContext: PresentedOfferingContext` - Currently it only has a `offeringIdentifier: String` - Eventually this will add new optional properties for targeting and placements
joshdholtz
added a commit
that referenced
this pull request
Feb 28, 2024
This was already approved and merged into `5.0-dev` but bringing this into `4.x` (see #3690) ### Motivation Allow for storing of other presented offering context on a `Package` ### Description - Replaced `offeringIdentifier: String` on `Package` with new `presentedOfferingContext: PresentedOfferingContext` - Currently it only has a `offeringIdentifier: String` - Eventually this will add new optional properties for targeting and placements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Allow for storing of other presented offering context on a
PackageDescription
offeringIdentifier: StringonPackagewith newpresentedOfferingContext: PresentedOfferingContextofferingIdentifier: String