Skip to content

Fix typo in zh-Hans localization of RevenueCatUI#3512

Merged
NachoSoto merged 1 commit into
RevenueCat:mainfrom
francisfeng:patch-1
Dec 11, 2023
Merged

Fix typo in zh-Hans localization of RevenueCatUI#3512
NachoSoto merged 1 commit into
RevenueCat:mainfrom
francisfeng:patch-1

Conversation

@francisfeng

@francisfeng francisfeng commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

“終” is Traditional Chinese while “终” is Simplified Chinese.

@NachoSoto NachoSoto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NachoSoto NachoSoto merged commit d757d74 into RevenueCat:main Dec 11, 2023
NachoSoto added a commit to RevenueCat/purchases-android that referenced this pull request Dec 11, 2023
NachoSoto pushed a commit that referenced this pull request Dec 12, 2023
**This is an automatic release.**

### RevenueCatUI
* `Paywalls`: improve image caching (#3498) via NachoSoto (@NachoSoto)
* `Paywalls`: change style of CTA button to be consistent with other
platforms (#3507) via NachoSoto (@NachoSoto)
* `Paywalls`: open footer links on Safari on Catalyst (#3508) via
NachoSoto (@NachoSoto)
* `Paywalls`: fix compilation on Xcode < 14.3 (#3513) via NachoSoto
(@NachoSoto)
* Fix typo in zh-Hans localization of RevenueCatUI (#3512) via Francis
Feng (@francisfeng)
* `Paywalls`: fix PaywallViewControllerDelegate access from Objective-C
(#3510) via noncenz (@noncenz)
* `Paywalls`: open Terms and Privacy Policy links in-app (#3475) via
Andy Boedo (@aboedo)
* `Paywalls`: fix empty description when using `custom` package type and
`{{ sub_period }}` (#3495) via Andy Boedo (@aboedo)
* `Paywalls`: use `HEIC` images (#3496) via NachoSoto (@NachoSoto)
* Paywalls: disable the close button when an action is in progress
(#3474) via Andy Boedo (@aboedo)
* `Paywalls`: adjusted German translations (#3476) via Tensei (@tensei)
* Paywalls: Improve Chinese localization (#3489) via Andy Boedo
(@aboedo)
### Other Changes
* `CircleCI`: add git credentials to snapshot generation (#3506) via
NachoSoto (@NachoSoto)
* `StoreProduct`: improve `priceFormatter` documentation (#3500) via
NachoSoto (@NachoSoto)
* `Paywalls`: fix tests (#3499) via NachoSoto (@NachoSoto)
* `Optimization`: changed `first` to `first(where:)` (#3467) via
NachoSoto (@NachoSoto)
facumenzella added a commit that referenced this pull request May 28, 2026
…llView

Adds a @_spi(Internal) WorkflowPaywallView init that accepts an injected
WorkflowNavigator, enabling tests to drive navigation on the same instance
held by the view. This keeps the public init clean and marks the seam
explicitly as not part of the external API.

Adds three navigation-after tests (purchase after forward nav, restore after
forward nav, purchase after forward-then-back) mirroring Android PR #3512,
addressing vegaro's review concern that navigating between steps could break
listener wiring.

Also guards all callback test sections with !os(watchOS) && !os(macOS) since
addToHierarchy() is UIKit-only (Bugbot finding).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
facumenzella added a commit that referenced this pull request Jun 2, 2026
…llView

Adds a @_spi(Internal) WorkflowPaywallView init that accepts an injected
WorkflowNavigator, enabling tests to drive navigation on the same instance
held by the view. This keeps the public init clean and marks the seam
explicitly as not part of the external API.

Adds three navigation-after tests (purchase after forward nav, restore after
forward nav, purchase after forward-then-back) mirroring Android PR #3512,
addressing vegaro's review concern that navigating between steps could break
listener wiring.

Also guards all callback test sections with !os(watchOS) && !os(macOS) since
addToHierarchy() is UIKit-only (Bugbot finding).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants