Paywalls: RevenueCatUI CocoaPods support#3368
Merged
Merged
Conversation
NachoSoto
commented
Oct 31, 2023
| name = SPMInstallation; | ||
| packageProductDependencies = ( | ||
| B3A9296026E2AAFB00C5E699 /* RevenueCat */, | ||
| 4F3810982AF1B98200441136 /* RevenueCatUI */, |
Contributor
Author
There was a problem hiding this comment.
SPMInstallation will now test this as well.
aboedo
approved these changes
Nov 1, 2023
| end | ||
|
|
||
| def push_revenuecatui_pod | ||
| pod_push(path: "RevenueCatUI.podspec", synchronous: true) |
Member
There was a problem hiding this comment.
we technically don't need synchronous for this one, but it can't hurt to have it
Comment on lines
+721
to
+732
| command: bundle exec fastlane push_revenuecat_pod | ||
| no_output_timeout: 30m | ||
|
|
||
| push-revenuecatui-pod: | ||
| <<: *base-job | ||
| steps: | ||
| - checkout | ||
| - install-bundle-dependencies | ||
| - trust-github-key | ||
| - run: | ||
| name: Deploy new version | ||
| command: bundle exec fastlane push_revenuecatui_pod |
Member
There was a problem hiding this comment.
why not move this to the fastlane level?
Contributor
Author
There was a problem hiding this comment.
You mean combining both?
So we can retry each individually if any of them fail without having to push code to do that.
0cdebb6 to
f343836
Compare
NachoSoto
commented
Nov 1, 2023
| <<: *release-branches | ||
| - installation-tests-cocoapods: | ||
| xcode_version: '14.3.0' | ||
| <<: *release-branches |
Contributor
Author
There was a problem hiding this comment.
18eaba4 to
458c3a8
Compare
458c3a8 to
06f7bb0
Compare
NachoSoto
pushed a commit
that referenced
this pull request
Nov 2, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: `RevenueCatUI` CocoaPods support (#3368) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3152.