Paywalls: watchOS support#3291
Merged
Merged
Conversation
NachoSoto
commented
Oct 9, 2023
Contributor
14407f7 to
17a1f48
Compare
NachoSoto
commented
Oct 9, 2023
| paywallRevision: 5, | ||
| sessionID: .init(uuidString: "98CC0F1D-7665-4093-9624-1D7308FFF4DB")!, | ||
| displayMode: .condensedFooter, | ||
| displayMode: .fullScreen, |
Contributor
Author
There was a problem hiding this comment.
.fullScreen is the only available on in watchOS, so I changed this to fix those tests.
aaa8455 to
caa4b31
Compare
caa4b31 to
480c5b5
Compare
895851d to
a3623bc
Compare
23ff954 to
e27fec7
Compare
ed5dce9 to
9d38c3e
Compare
NachoSoto
commented
Nov 15, 2023
| } | ||
|
|
||
| #if os(watchOS) | ||
| // `Locale.current` in watchOS produces `en_001` when running tests |
Contributor
Author
There was a problem hiding this comment.
tonidero
approved these changes
Nov 16, 2023
| import SwiftUI | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| @available(tvOS, unavailable) |
Contributor
There was a problem hiding this comment.
Do we need to remove the watchOS from the lines above each of these?
Contributor
Author
There was a problem hiding this comment.
If you don't add it it assumes the requirement matches the deployment target in the target which is 6.2 so it fails to compile.
| if #unavailable(watchOS 10.0) { | ||
| Color.black | ||
| } | ||
| #endif |
Contributor
There was a problem hiding this comment.
Just to confirm, in the else case, I guess this will be nil, so there won't be any background, correct?
4ea9729 to
9e2e51b
Compare
NachoSoto
commented
Nov 16, 2023
| "tos_url" : null | ||
| }, | ||
| "localized_strings" : { | ||
| "en_001" : { |
Contributor
Author
There was a problem hiding this comment.
This is broken on watchOS + Xcode 15
214db96 to
7068c6a
Compare
tonidero
pushed a commit
that referenced
this pull request
Nov 30, 2023
**This is an automatic release.** ### RevenueCatUI * Paywalls: Fix navigation with close button in UIKit (#3466) via Andy Boedo (@aboedo) * `Paywalls`: `watchOS` support (#3291) via NachoSoto (@NachoSoto) ### Dependency Updates * Bump cocoapods from 1.14.2 to 1.14.3 (#3464) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.216.0 to 2.217.0 (#3415) via dependabot[bot] (@dependabot[bot]) * Bump danger from 9.3.2 to 9.4.0 (#3414) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Some `APITester` fixes (#3444) via NachoSoto (@NachoSoto) * `HTTPClient`: test all request headers (#3425) via NachoSoto (@NachoSoto) * `CircleCI`: fix snapshot generation for iOS 14 (#3431) via NachoSoto (@NachoSoto) * Remove `MockStoreMessagesHelper` from SDK (#3417) via NachoSoto (@NachoSoto) * Enable explicit_init lint rule and fix issues (#3418) via Mark Villacampa (@MarkVillacampa)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.