Paywalls Tester: group live paywalls by template#3276
Merged
Conversation
Contributor
Author
|
I recommend reviewing this ignoring whitespaces. |
aboedo
approved these changes
Oct 4, 2023
| let offerings = try await Purchases.shared.offerings() | ||
| .all | ||
| .map(\.value) | ||
| .sorted { $0.serverDescription > $1.serverDescription } |
Member
There was a problem hiding this comment.
we can delete this sorting now, right? we have it again on line 51
Contributor
Author
There was a problem hiding this comment.
That one is sorting keys (templates). This is sorting the values (offerings) by name.
This was referenced Oct 6, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Oct 6, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: improved purchase-in-progress UI (#3279) via NachoSoto (@NachoSoto) ### Bugfixes * `SK2StoreProduct.priceFormatter`: use locale from `StoreKit.Product` (#3278) via NachoSoto (@NachoSoto) ### Performance Improvements * `AAAttribution.attributionToken`: avoid using on main thread (#3281) via NachoSoto (@NachoSoto) ### Other Changes * `Paywalls Tester`: group live paywalls by template (#3276) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.