PostedTransactionCache: add a TTL to every transaction#3023
Closed
NachoSoto wants to merge 1 commit into
Closed
Conversation
This was suggested in #2914 as a way to prevent the cache from growing forever. ### Other changes: - Added `PostedTransactionCache.unpostedTransactions`: this was added in #2914, so I put it here to prevent merge conflicts. - `PostedTransactionCache` now verifies that cache interaction doesn't happen in the main thread - Added debug log when saving transactions - Added debug log when pruning cache - Added `ClockType` tests
NachoSoto
commented
Aug 16, 2023
Comment on lines
+47
to
+48
| self.pruneOldTransactions(from: &transactions) | ||
| transactions[transaction.transactionIdentifier] = self.clock.now |
Contributor
Author
There was a problem hiding this comment.
This entire modification is done in place so we don't end up with 2 dictionary copies in memory.
NachoSoto
commented
Aug 16, 2023
| expect(self.cache.hasPostedTransaction(transaction2)) == true | ||
| } | ||
|
|
||
| func testHasPostedTransactionDoesNotTakeDateIntoAccount() { |
Contributor
Author
There was a problem hiding this comment.
This makes hasPostedTransaction faster, we only prune when writing.
4 tasks
Contributor
Author
|
Closing this. As shown in #3020 this won't work with that 😢 |
NachoSoto
added a commit
that referenced
this pull request
Aug 17, 2023
This is extracted from #3023. That's closed but this is still useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was suggested in #2914 as a way to prevent the cache from growing forever.
Other changes:
PostedTransactionCache.unpostedTransactions: this was added inTransactionPoster: avoid posting transactions multiple times #2914, so I put it here to prevent merge conflicts.PostedTransactionCachenow verifies that cache interaction doesn't happen in the main threadClockTypetests