Skip to content

Expanded EnsureNonEmptyArrayDecodable to EnsureNonEmptyCollectionDecodable#3002

Merged
NachoSoto merged 1 commit into
mainfrom
ensure-non-empty-collection
Aug 14, 2023
Merged

Expanded EnsureNonEmptyArrayDecodable to EnsureNonEmptyCollectionDecodable#3002
NachoSoto merged 1 commit into
mainfrom
ensure-non-empty-collection

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

This will be used for ensuring PaywallData localization isn't empty.

@NachoSoto NachoSoto requested review from a team August 10, 2023 23:14
@NachoSoto NachoSoto force-pushed the ensure-non-empty-collection branch from 3661faa to 1ef1770 Compare August 10, 2023 23:14
@NachoSoto NachoSoto mentioned this pull request Aug 10, 2023
Merged
@NachoSoto NachoSoto force-pushed the ensure-non-empty-collection branch from 1ef1770 to 4166f76 Compare August 11, 2023 18:51
@codecov

codecov Bot commented Aug 11, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3002 (60b1cfa) into main (161b04d) will decrease coverage by 0.11%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3002      +/-   ##
==========================================
- Coverage   86.68%   86.57%   -0.11%     
==========================================
  Files         219      219              
  Lines       15619    15619              
==========================================
- Hits        13539    13522      -17     
- Misses       2080     2097      +17
Files Changed Coverage Δ
...sc/Codable/EnsureNonEmptyCollectionDecodable.swift 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@NachoSoto NachoSoto force-pushed the ensure-non-empty-collection branch from 4166f76 to 60b1cfa Compare August 11, 2023 21:32
@NachoSoto NachoSoto merged commit 7a23d5b into main Aug 14, 2023
@NachoSoto NachoSoto deleted the ensure-non-empty-collection branch August 14, 2023 14:35
NachoSoto added a commit that referenced this pull request Aug 14, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
448ea21 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
This was referenced Aug 16, 2023
Closed
Merged
NachoSoto pushed a commit that referenced this pull request Aug 17, 2023
@RCGitBot
[AUTOMATIC] Release/4.25.5 (#3033)
7629e2a 
**This is an automatic release.**

### Bugfixes
* `PurchasesOrchestrator`: fixed callback not invoked regression during
downgrades (#3028) via NachoSoto (@NachoSoto)
* `TransactionPoster`: don't finish transactions for non-subscriptions
if they're not processed (#2841) via NachoSoto (@NachoSoto)
### Performance Improvements
* `StoreKit 2`: only listen to `StoreKit.Transaction.updates` when SK2
is enabled (#3032) via NachoSoto (@NachoSoto)
* `CustomerInfoManager`: post transactions in parallel to POST receipts
only once (#2954) via NachoSoto (@NachoSoto)
### Other Changes
* `PostedTransactionCache`: remove implementation (#3030) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improved `testCanPurchaseMultipleSubscriptions`
(#3025) via NachoSoto (@NachoSoto)
* `GitHub`: improved `ISSUE_TEMPLATE` (#3022) via NachoSoto (@NachoSoto)
* `TransactionPoster`: added transaction ID and Date to log (#3026) via
NachoSoto (@NachoSoto)
* `TransactionPoster`: fix iOS 12 test (#3018) via NachoSoto
(@NachoSoto)
* `SystemInfo`: added `ClockType` (#3014) via NachoSoto (@NachoSoto)
* `Integration Tests`: begin tests with
`UIApplication.willEnterForegroundNotification` to simulate a real app
(#3015) via NachoSoto (@NachoSoto)
* `Integration Tests`: add tests to verify `CustomerInfo`+`Offerings`
request de-dupping (#3013) via NachoSoto (@NachoSoto)
* `SwiftLint`: disable `unneeded_synthesized_initializer` (#3010) via
NachoSoto (@NachoSoto)
* Added `internal`
`NonSubscriptionTransaction.storeTransactionIdentifier` (#3009) via
NachoSoto (@NachoSoto)
* `Integration Tests`: added tests for non-renewing and non-consumable
packages (#3008) via NachoSoto (@NachoSoto)
* Expanded `EnsureNonEmptyArrayDecodable` to
`EnsureNonEmptyCollectionDecodable` (#3002) via NachoSoto (@NachoSoto)
NachoSoto added a commit that referenced this pull request Aug 17, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
54bad26 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Aug 24, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
f689850 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
@NachoSoto NachoSoto mentioned this pull request Aug 26, 2023
Closed
NachoSoto added a commit that referenced this pull request Aug 28, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
fcd674c 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
@NachoSoto NachoSoto mentioned this pull request Aug 31, 2023
Closed
NachoSoto added a commit that referenced this pull request Aug 31, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
78a501d 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 1, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
d02b503 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 6, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
77c6b6f 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 6, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
a4fde44 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 6, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
5e0c6eb 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
@NachoSoto @MarkVillacampa
Expanded EnsureNonEmptyArrayDecodable to `EnsureNonEmptyCollectionD…
488d411 
…ecodable` (#3002)
MarkVillacampa pushed a commit that referenced this pull request Sep 6, 2023
@RCGitBot @MarkVillacampa
[AUTOMATIC] Release/4.25.5 (#3033)
d08f35d 
**This is an automatic release.**

### Bugfixes
* `PurchasesOrchestrator`: fixed callback not invoked regression during
downgrades (#3028) via NachoSoto (@NachoSoto)
* `TransactionPoster`: don't finish transactions for non-subscriptions
if they're not processed (#2841) via NachoSoto (@NachoSoto)
### Performance Improvements
* `StoreKit 2`: only listen to `StoreKit.Transaction.updates` when SK2
is enabled (#3032) via NachoSoto (@NachoSoto)
* `CustomerInfoManager`: post transactions in parallel to POST receipts
only once (#2954) via NachoSoto (@NachoSoto)
### Other Changes
* `PostedTransactionCache`: remove implementation (#3030) via NachoSoto
(@NachoSoto)
* `Integration Tests`: improved `testCanPurchaseMultipleSubscriptions`
(#3025) via NachoSoto (@NachoSoto)
* `GitHub`: improved `ISSUE_TEMPLATE` (#3022) via NachoSoto (@NachoSoto)
* `TransactionPoster`: added transaction ID and Date to log (#3026) via
NachoSoto (@NachoSoto)
* `TransactionPoster`: fix iOS 12 test (#3018) via NachoSoto
(@NachoSoto)
* `SystemInfo`: added `ClockType` (#3014) via NachoSoto (@NachoSoto)
* `Integration Tests`: begin tests with
`UIApplication.willEnterForegroundNotification` to simulate a real app
(#3015) via NachoSoto (@NachoSoto)
* `Integration Tests`: add tests to verify `CustomerInfo`+`Offerings`
request de-dupping (#3013) via NachoSoto (@NachoSoto)
* `SwiftLint`: disable `unneeded_synthesized_initializer` (#3010) via
NachoSoto (@NachoSoto)
* Added `internal`
`NonSubscriptionTransaction.storeTransactionIdentifier` (#3009) via
NachoSoto (@NachoSoto)
* `Integration Tests`: added tests for non-renewing and non-consumable
packages (#3008) via NachoSoto (@NachoSoto)
* Expanded `EnsureNonEmptyArrayDecodable` to
`EnsureNonEmptyCollectionDecodable` (#3002) via NachoSoto (@NachoSoto)
NachoSoto added a commit that referenced this pull request Sep 7, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
897ed6f 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 7, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
95e34ee 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 8, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
8a7d33e 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 14, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
a9ac87e 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 14, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
cf6073a 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
NachoSoto added a commit that referenced this pull request Sep 15, 2023
@NachoSoto
Paywalls: replaced defaultLocale with preferredLocales (#3003)
f557eda 
Depends on #3002.

This is the new logic for finding the locale to use

```swift
var localizedConfiguration: LocalizedConfiguration {
    let locales: [Locale] = [.current] + Locale.preferredLocales

    return locales
        .lazy
        .compactMap(self.config(for:))
        .first ?? self.fallbackLocalizedConfiguration
}
```

And note that `config(for:)` is a fuzzy-lookup (#2847).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NachoSoto @joshdholtz