Paywalls: added packages to configuration#2798
Merged
Merged
Conversation
0473a5a to
e2fc47f
Compare
44d9fd5 to
39ec1f8
Compare
joshdholtz
requested changes
Jul 13, 2023
joshdholtz
left a comment
Member
There was a problem hiding this comment.
Looks good but I think I found one thing we don't want to commit 🤷♂️
6f7c1ce to
5e4b77c
Compare
39ec1f8 to
ad3bccf
Compare
5e4b77c to
d7ebaab
Compare
ad3bccf to
fcbf94a
Compare
joshdholtz
approved these changes
Jul 13, 2023
This allows configuring which package(s) will be displayed in each paywall.
fcbf94a to
aafff15
Compare
aboedo
reviewed
Jul 13, 2023
Comment on lines
+29
to
+30
| let offering = TestData.offeringWithIntroOffer | ||
| PaywallView(offering: offering, paywall: offering.paywall!) |
Member
There was a problem hiding this comment.
might as well do an if let here and have a text explaining that there's no offering so the preview doesn't ugly-crash?
I.e.:
let offering = TestData.offeringWithIntroOffer
if let paywall = offering.paywall {
PaywallView(offering: offering, paywall: paywall)
} else {
Text("Preview not correctly set up! The offering's paywall need to be non-nil")
}
Contributor
Author
There was a problem hiding this comment.
👍🏻 I guess debugging crashes in previews is annoying, so yeah.
Contributor
Author
There was a problem hiding this comment.
Done in the next PR.
NachoSoto
added a commit
that referenced
this pull request
Jul 13, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 13, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 14, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Jul 14, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Jul 24, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Jul 24, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 24, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Jul 25, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 25, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Jul 26, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 26, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Jul 27, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 27, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Jul 31, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 31, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Aug 3, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 3, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Aug 7, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 7, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Aug 9, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 9, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Aug 11, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 11, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Aug 14, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 14, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
NachoSoto
added a commit
that referenced
this pull request
Aug 17, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 17, 2023
Some missing tests for the logic added in #2798. I've also moved this function to be fined in `PaywallData` instead of the `TemplateViewType` protocol, which makes more sense.
This was referenced Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows configuring which package(s) will be displayed in each paywall.