Paywalls: add support for displaying StoreProductDiscounts#2796
Merged
Conversation
NachoSoto
commented
Jul 12, 2023
Contributor
0473a5a to
e2fc47f
Compare
4a8cf1a to
b5ee15a
Compare
6f7c1ce to
5e4b77c
Compare
Contributor
Author
|
Oh gotta add a check for whether the user is eligible. |
5e4b77c to
d7ebaab
Compare
Contributor
Author
Doing that in a separate PR. |
aboedo
reviewed
Jul 13, 2023
Comment on lines
+9
to
+11
| var callToActionWithIntroOffer: String | ||
| var offerDetails: String | ||
| var offerDetailsWithIntroOffer: String |
Member
There was a problem hiding this comment.
maybe these should be optional, not all products have an intro offer
Contributor
Author
There was a problem hiding this comment.
Doing in the next PR 👍🏻
NachoSoto
added a commit
that referenced
this pull request
Jul 13, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 20, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Jul 23, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 23, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Jul 24, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 24, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Jul 24, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 24, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Jul 25, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 25, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Jul 26, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 26, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Jul 27, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 27, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Jul 31, 2023
NachoSoto
added a commit
that referenced
this pull request
Jul 31, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Aug 3, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 3, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Aug 7, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 7, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Aug 9, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 9, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
NachoSoto
added a commit
that referenced
this pull request
Aug 11, 2023
NachoSoto
added a commit
that referenced
this pull request
Aug 11, 2023
Follow up to #2796. This also makes `PaywallData.Configuration`'s intro strings optional. ### Other changes: - Injected `TrialOrIntroEligibilityChecker` - Created mock `TrialOrIntroEligibilityChecker` for previews - Handling state and transitions for loading eligibility - Snapshot tests for the different new cases - Improved `SnapshotTesting` delay management - Expanded `DebugErrorView` to customize release behavior
This was referenced Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.