Skip to content

Paywalls: using PaywallData and setting up basic template loading#2781

Merged
NachoSoto merged 1 commit into
paywallsfrom
paywalls-using-config
Jul 13, 2023
Merged

Paywalls: using PaywallData and setting up basic template loading#2781
NachoSoto merged 1 commit into
paywallsfrom
paywalls-using-config

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Jul 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This adds a new TemplateViewType that different templates can conform to.
PaywallView now takes PaywallData and renders the paywall depending on its template.

@NachoSoto NachoSoto requested a review from a team July 10, 2023 23:20
@NachoSoto NachoSoto force-pushed the paywalls-using-config branch from e6062df to 938a24f Compare July 10, 2023 23:23
@NachoSoto NachoSoto force-pushed the paywalls-using-config branch from 938a24f to 576c60a Compare July 10, 2023 23:29
@NachoSoto NachoSoto force-pushed the paywall-config branch 2 times, most recently from 06c9e6f to 55ff780 Compare July 11, 2023 19:27
@NachoSoto NachoSoto force-pushed the paywalls-using-config branch 2 times, most recently from 46272c3 to c1a8f9e Compare July 11, 2023 20:03
@NachoSoto NachoSoto changed the title [WIP] Paywalls: using PaywallData and setting up basic template loading Paywalls: using PaywallData and setting up basic template loading Jul 11, 2023
@NachoSoto NachoSoto marked this pull request as ready for review July 11, 2023 20:04
@NachoSoto NachoSoto force-pushed the paywalls-using-config branch from c1a8f9e to 4291164 Compare July 11, 2023 20:07
joshdholtz
joshdholtz approved these changes Jul 12, 2023
View reviewed changes

@joshdholtz joshdholtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@NachoSoto NachoSoto force-pushed the paywalls-using-config branch from 4291164 to 7809cd7 Compare July 12, 2023 13:08
@NachoSoto NachoSoto force-pushed the paywall-config branch 11 times, most recently from 29de25c to 2f5f5bc Compare July 12, 2023 22:29
NachoSoto added a commit that referenced this pull request Jul 13, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
408bc05 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 13, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
2b3b900 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 13, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
4a51d7d 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 13, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
a589ee2 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 17, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
bc7ac23 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 18, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
c988afd 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 18, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
3962fc6 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 20, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
e0a2d6d 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 23, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
b93ee09 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 24, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
bb684a5 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 24, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
2f54418 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 25, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
9c30927 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 26, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
a864934 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 27, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
1c95830 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Jul 31, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
6d32f75 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Aug 3, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
6699af3 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Aug 7, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
159031a 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Aug 9, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
0adb641 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Aug 11, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
e973f48 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Aug 14, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
f3de079 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Aug 17, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
d57af2a 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
NachoSoto added a commit that referenced this pull request Aug 24, 2023
@NachoSoto
Paywalls: using PaywallData and setting up basic template loading (…
ee98fff 
…#2781)

This adds a new `TemplateViewType` that different templates can conform
to.
`PaywallView` now takes `PaywallData` and renders the paywall depending
on its template.
This was referenced Aug 26, 2023
Closed
Closed
@NachoSoto NachoSoto mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshdholtz joshdholtz joshdholtz approved these changes

Assignees

No one assigned

Labels

pr:RevenueCatUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NachoSoto @joshdholtz