`Paywalls`: initial configuration types by NachoSoto · Pull Request #2780 · RevenueCat/purchases-ios

NachoSoto · 2023-07-10T22:41:52Z

Changes:

Added Offering.paywall
Decoding PaywallData in OfferingsResponse, using IgnoreDecodeErrors (this will be better after IgnoreDecodeErrors: log decoding error #2778)
New PaywallData struct
Added new APIs to testers
Testing paywall deserialization from Offerings
Testing paywall deserialization separately to check edge cases

Other changes:

Made DefaultDecodable and AnyDecodable Sendable

NachoSoto · 2023-07-11T19:37:58Z

Important that we don't fail to load the offering if this fails. The error will get logged with #2778

+1000. At least for now

we should fail at the Paywalls SDK level though

This is what I'm thinking:

if let paywall = offering.paywall { // The paywall is required PaywallView(offering: offering, paywall: paywall) } else { // You gotta handle it and do something yourself. }

With the public PaywallData constructor, users could to this:

} else { // This is hardcoded in the app let simplePaywall = PaywallData( template: .simple config: ... ) PaywallView(offering: offering, paywall: simplePaywall) }

NachoSoto · 2023-07-11T19:38:09Z

This is empty for now.

NachoSoto · 2023-07-11T19:38:21Z

This will obviously change, just a placeholder.

NachoSoto · 2023-07-11T19:38:35Z

We didn't update this when we exposed it for TestStoreProduct.

aboedo · 2023-07-11T20:06:13Z

these are the changes from #2776, right? do we need to rebase?

aboedo

❤️

aboedo · 2023-07-11T20:11:06Z

+1000. At least for now

aboedo · 2023-07-11T20:15:37Z

we should fail at the Paywalls SDK level though

joshdholtz

Few small comments but otherwise 💯

joshdholtz · 2023-07-12T03:33:35Z

This is a thing?! 🤯

Yeah to resolve ambiguity for types that conform to both protocols :)

- Added `Offering.paywall` - Decoding `PaywallData` in `OfferingsResponse`, using `IgnoreDecodeErrors` (this will be better after #2778) - New `PaywallData` `struct` - Added new APIs to testers - Testing paywall deserialization from `Offerings` - Testing paywall deserialization separately to check edge cases - Made `DefaultDecodable` and `AnyDecodable` `Sendable`

NachoSoto · 2023-07-13T04:21:14Z

Finally figured out the test issues: #2802.
I changed this test to also use expect {}.to(throwAssertion()) to fix it.

- Added `Offering.paywall` - Decoding `PaywallData` in `OfferingsResponse`, using `IgnoreDecodeErrors` (this will be better after #2778) - New `PaywallData` `struct` - Added new APIs to testers - Testing paywall deserialization from `Offerings` - Testing paywall deserialization separately to check edge cases

NachoSoto added the pr:feat A new feature label Jul 10, 2023

NachoSoto requested a review from a team July 10, 2023 22:41

NachoSoto force-pushed the paywall-config branch 4 times, most recently from 06c9e6f to 55ff780 Compare July 11, 2023 19:27

NachoSoto commented Jul 11, 2023

View reviewed changes

Comment thread Sources/Paywalls/PaywallData.swift Outdated

NachoSoto Jul 11, 2023

Copy link
Copy Markdown

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is empty for now.

NachoSoto commented Jul 11, 2023

View reviewed changes

NachoSoto marked this pull request as ready for review July 11, 2023 19:39

NachoSoto changed the title ~~[WIP] Paywalls: initial configuration types~~ Paywalls: initial configuration types Jul 11, 2023

NachoSoto added the pr:RevenueCatUI label Jul 11, 2023

NachoSoto force-pushed the paywall-config branch from 55ff780 to 0e0c0c7 Compare July 11, 2023 19:50

Base automatically changed from nacho/paywall-target to paywalls July 11, 2023 20:04

NachoSoto force-pushed the paywalls branch from be4046e to 9d9febe Compare July 11, 2023 20:05

aboedo reviewed Jul 11, 2023

View reviewed changes

NachoSoto force-pushed the paywall-config branch from 0e0c0c7 to eed569a Compare July 11, 2023 20:06

aboedo approved these changes Jul 11, 2023

View reviewed changes

NachoSoto force-pushed the paywall-config branch 2 times, most recently from 236de6f to 962b498 Compare July 11, 2023 21:54

joshdholtz approved these changes Jul 12, 2023

View reviewed changes

NachoSoto force-pushed the paywalls branch from 9d9febe to 9c0b33c Compare July 12, 2023 13:07

NachoSoto force-pushed the paywall-config branch 4 times, most recently from a8fd3b0 to f2a5df3 Compare July 12, 2023 16:12

NachoSoto force-pushed the paywalls branch from 9c0b33c to 7eb88af Compare July 12, 2023 17:34

NachoSoto added 2 commits July 12, 2023 10:35

Updated snapshots

31f1152

NachoSoto force-pushed the paywall-config branch from a3f8ea0 to fb95238 Compare July 13, 2023 04:20

NachoSoto merged commit b192d6a into paywalls Jul 13, 2023

NachoSoto deleted the paywall-config branch July 13, 2023 04:27

This was referenced Aug 26, 2023

[DO NOT MERGE] Release/4.26.0-beta.1 #3102

Closed

[DO NOT MERGE] Release/4.26.0-beta.2 #3127

Closed

NachoSoto mentioned this pull request Sep 15, 2023

[AUTOMATIC] Release/4.26.0 #3219

Merged

Conversation

NachoSoto commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Other changes:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aboedo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshdholtz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NachoSoto commented Jul 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NachoSoto commented Jul 10, 2023 •

edited

Loading