Skip to content

AnyEncodable: also implement Decodable#2769

Merged
NachoSoto merged 1 commit into
mainfrom
any-encodable-decodable
Jul 7, 2023
Merged

AnyEncodable: also implement Decodable#2769
NachoSoto merged 1 commit into
mainfrom
any-encodable-decodable

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

This will be used for an upcoming test that uses AnyEncodable and needs to extract the contents.

This will be used for an upcoming test that uses `AnyEncodable` and needs to extract the contents.
}

/// `AnyEncodable` can also be decoded
extension AnyEncodable: Decodable {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like we should make this AnyCodable now?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing that in a separate PR cause it ended up a bit more work.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented Jul 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2769 (e82c1da) into main (edd5a23) will decrease coverage by 0.01%.
The diff coverage is 71.87%.

@@            Coverage Diff             @@
##             main    #2769      +/-   ##
==========================================
- Coverage   86.48%   86.47%   -0.01%     
==========================================
  Files         214      214              
  Lines       15336    15368      +32     
==========================================
+ Hits        13263    13290      +27     
- Misses       2073     2078       +5     
Impacted Files Coverage Δ
Sources/Misc/Codable/AnyEncodable.swift 74.32% <71.87%> (-1.87%) ⬇️

... and 5 files with indirect coverage changes

@NachoSoto NachoSoto merged commit a505f04 into main Jul 7, 2023
@NachoSoto NachoSoto deleted the any-encodable-decodable branch July 7, 2023 22:18
NachoSoto added a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants