XCFramework: sign archive for Xcode 15#2709
Merged
Merged
Conversation
It's useful to have it in `release_checks` lane, to make sure that our framework can be built with `Carthage`. However, what we actually release is using `export_xcframework`, which also builds the frameworks. This will make `release` MUCH faster since we no longer build everything twice as many times (and for each platform / architecture combination).
20f4e30 to
03d6e9d
Compare
5d1bd62 to
5c44944
Compare
0998c1f to
2cf7ac8
Compare
XCFramework: sign archive for Xcode 15XCFramework: sign archive for Xcode 15
Codecov Report
@@ Coverage Diff @@
## release-carthage-archive #2709 +/- ##
===========================================================
Coverage ? 86.55%
===========================================================
Files ? 211
Lines ? 15023
Branches ? 0
===========================================================
Hits ? 13003
Misses ? 2020
Partials ? 0 |
joshdholtz
approved these changes
Jun 27, 2023
joshdholtz
left a comment
Member
There was a problem hiding this comment.
Looks good! And will work on adding this into fastlane 💪
NachoSoto
commented
Jun 27, 2023
| type: 'appstore', | ||
| skip_provisioning_profiles: true, | ||
| # This isn't important, we just need to fetch the certificate | ||
| app_identifier: "com.revenuecat.CarthageIntegration" |
Contributor
Author
There was a problem hiding this comment.
BTW @joshdholtz how come this is required if we’re skipping provisioning profiles?
NachoSoto
added a commit
that referenced
this pull request
Jun 30, 2023
**This is an automatic release.** ### New Features * New `TestStoreProduct` for creating mock `StoreProduct`s and `Offering`s (#2711) via NachoSoto (@NachoSoto) ✨ With this new API you can now create fake products for unit tests and SwiftUI previews! 🎉 #### Example: ```swift let product = TestStoreProduct( localizedTitle: "PRO monthly", price: 3.99, localizedPriceString: "$3.99", productIdentifier: "com.revenuecat.product", productType: .autoRenewableSubscription, localizedDescription: "Description", subscriptionGroupIdentifier: "group", subscriptionPeriod: .init(value: 1, unit: .month) ) let offering = Offering( identifier: "offering", serverDescription: "Main offering", metadata: [:], availablePackages: [ .init( identifier: "monthly", packageType: .monthly, storeProduct: product.toStoreProduct(), offeringIdentifier: offering ) ] ) ``` ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `13773d2` to `b2108fb` (#2706) via dependabot[bot] (@dependabot[bot]) ### Other Changes * `VerificationResult: CustomDebugStringConvertible` (#2739) via NachoSoto (@NachoSoto) * Refactor: simplified `PurchasesOrchestrator.syncPurchases` (#2731) via NachoSoto (@NachoSoto) * `Trusted Entitlements`: add integration tests to verify `CustomerInfo` cache invalidation (#2730) via NachoSoto (@NachoSoto) * `SystemInfo.identifierForVendor`: add tests (#2732) via NachoSoto (@NachoSoto) * `Tests`: disabled `iOS 11.x` tests to fix `Xcode 15` tests (#2720) via NachoSoto (@NachoSoto) * `DebugViewSwiftUITests`: create separate snapshots for each OS version (#2721) via NachoSoto (@NachoSoto) * `Integration Tests`: fix clearing `UserDefaults` before each test (#2719) via NachoSoto (@NachoSoto) * Remove unused `Signing.loadPublicKey(with:)` (#2714) via NachoSoto (@NachoSoto) * Add `UInt32(littleEndian32Bits:)` and `UInt32.littleEndianData` (#2713) via NachoSoto (@NachoSoto) * `TimingUtil`: added synchronous API (#2716) via NachoSoto (@NachoSoto) * `XCFramework`: sign archive for `Xcode 15` (#2709) via NachoSoto (@NachoSoto) * `CI`: removed `carthage_archive` from `release` lane (#2710) via NachoSoto (@NachoSoto) * `PriceFormatterProvider.priceFormatterForSK2`: enable on all versions (#2712) via NachoSoto (@NachoSoto) * `xrOS`: add support for `debugRevenueCatOverlay` (#2702) via NachoSoto (@NachoSoto) * Refactor method to get product ID including plan ID in android purchases (#2708) via Toni Rico (@tonidero) * `Purchases.restoreLogHandler` (#2699) via NachoSoto (@NachoSoto) * Remove alpha from purchase tester icon to upload to testflight (#2705) via Toni Rico (@tonidero) --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I filed fastlane/fastlane#21359, but for now we can do this ourselves.
Motivation
This is what happens with Xcode 15 if you try to build with an unsigned
XCFramework:That breaks the build until you accept it.
With the signature
This can be inspected in Xcode:
When using Xcode 15, this modifies the project to save the known signature:
But the
.xcframeworkremains compatible with Xcode 14.