ETagManager: add API key to ETag content#2665
Closed
NachoSoto wants to merge 1 commit into
Closed
Conversation
This fixes the following scenario: - User makes initial requests with invalid API key - 401 response - We store that response (`ErrorResponse`) - User fixes the API key - Server returns 304 - We return the cached body for the `ErrorResponse`
Contributor
Author
|
Closing this since the backend is no longer sending etags in 401s. |
NachoSoto
added a commit
that referenced
this pull request
Jun 21, 2023
We had lots of different parts of the code doing `request.url?.absoluteString` and also using different values for e-tags. This refactor combines all that to use a single `eTag(for:)` method. I did this as part of #2665, which is getting closed, but it will still be useful if we ever decide to change the content of e-tags.
NachoSoto
added a commit
that referenced
this pull request
Jun 21, 2023
We had lots of different parts of the code doing `request.url?.absoluteString` and also using different values for e-tags. This refactor combines all that to use a single `eTag(for:)` method. I did this as part of #2665, which is getting closed, but it will still be useful if we ever decide to change the content of e-tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following scenario:
ErrorResponse)ErrorResponseThis is a proposed fix for COIN-595. Instead of this, we might want to ensure that 401 responses don't return etags.