Skip to content

Dictionary.MergeStrategy: fixed Xcode 15 compilation#2582

Merged
NachoSoto merged 1 commit into
mainfrom
swift-6-fix-1
Jun 5, 2023
Merged

Dictionary.MergeStrategy: fixed Xcode 15 compilation#2582
NachoSoto merged 1 commit into
mainfrom
swift-6-fix-1

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

Generic parameter 'Value' shadows generic parameter from outer scope with the same name; this is an error in Swift 6

@NachoSoto NachoSoto added pr:fix A bug fix iOS 17 labels Jun 5, 2023
@NachoSoto NachoSoto requested a review from a team June 5, 2023 23:09
@NachoSoto NachoSoto enabled auto-merge (squash) June 5, 2023 23:23

@joshdholtz joshdholtz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@NachoSoto NachoSoto merged commit 0044474 into main Jun 5, 2023
@NachoSoto NachoSoto deleted the swift-6-fix-1 branch June 5, 2023 23:45
NachoSoto added a commit that referenced this pull request Jun 6, 2023
Follow up to #2582. Didn't realize that the issue was the `Value` shouldn't have been there, since it could use the parent `associatedtype` from `Dictionary`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants